Bug 132037

Summary:

Transition RenderTheme API from RenderObject* to const RenderObject&

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, darin, dino, jonlee, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

alan

Reported 2014-04-22 20:51:41 PDT

ssia. patch is coming up.

Attachments
Patch (119.70 KB, patch) 2014-04-23 08:32 PDT, alan	no flags	Details Formatted Diff Diff
Patch (148.00 KB, patch) 2014-04-23 20:34 PDT, alan	no flags	Details Formatted Diff Diff
Patch (215.52 KB, patch) 2014-04-23 21:23 PDT, alan	no flags	Details Formatted Diff Diff
Patch (236.33 KB, patch) 2014-04-23 21:49 PDT, alan	no flags	Details Formatted Diff Diff
Patch (236.33 KB, patch) 2014-04-23 22:14 PDT, alan	no flags	Details Formatted Diff Diff
Patch (236.32 KB, patch) 2014-04-24 06:50 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2014-04-23 08:32:22 PDT

Created attachment 229988 [details] Patch

Andreas Kling

Comment 2 2014-04-23 14:00:33 PDT

This seems like a great thing to be doing, just needs some build fixes. :)

alan

Comment 3 2014-04-23 20:34:05 PDT

Created attachment 230042 [details] Patch

alan

Comment 4 2014-04-23 20:34:26 PDT

Comment on attachment 230042 [details] Patch EWSing

alan

Comment 5 2014-04-23 21:23:43 PDT

Created attachment 230045 [details] Patch

alan

Comment 6 2014-04-23 21:23:58 PDT

Comment on attachment 230045 [details] Patch more EWS

alan

Comment 7 2014-04-23 21:49:15 PDT

Created attachment 230048 [details] Patch

alan

Comment 8 2014-04-23 21:49:37 PDT

Comment on attachment 230048 [details] Patch and some more

alan

Comment 9 2014-04-23 22:14:05 PDT

Created attachment 230049 [details] Patch

alan

Comment 10 2014-04-23 22:14:30 PDT

Comment on attachment 230049 [details] Patch and more.

WebKit Commit Bot

Comment 11 2014-04-24 06:48:36 PDT

Comment on attachment 230049 [details] Patch Rejecting attachment 230049 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 230049, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Andreas Goran Kling found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5649573959696384

alan

Comment 12 2014-04-24 06:50:55 PDT

Created attachment 230076 [details] Patch

alan

Comment 13 2014-04-24 06:51:45 PDT

Comment on attachment 230076 [details] Patch Andreas -Goran Kling.

WebKit Commit Bot

Comment 14 2014-04-24 07:28:26 PDT

Comment on attachment 230076 [details] Patch Clearing flags on attachment: 230076 Committed r167755: <http://trac.webkit.org/changeset/167755>

WebKit Commit Bot

Comment 15 2014-04-24 07:28:30 PDT

All reviewed patches have been landed. Closing bug.

Darin Adler

Comment 16 2014-04-24 07:58:46 PDT

Not RenderElement?

alan

Comment 17 2014-04-24 08:02:38 PDT

(In reply to comment #16) > Not RenderElement? I need to fix some border painting dependency first in order to be able to move to RenderElement.

Note You need to log in before you can comment on or make changes to this bug.