Summary: | Transition RenderTheme API from RenderObject* to const RenderObject& | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bdakin, commit-queue, darin, dino, jonlee, kling | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
zalan
2014-04-22 20:51:41 PDT
Created attachment 229988 [details]
Patch
This seems like a great thing to be doing, just needs some build fixes. :) Created attachment 230042 [details]
Patch
Comment on attachment 230042 [details]
Patch
EWSing
Created attachment 230045 [details]
Patch
Comment on attachment 230045 [details]
Patch
more EWS
Created attachment 230048 [details]
Patch
Comment on attachment 230048 [details]
Patch
and some more
Created attachment 230049 [details]
Patch
Comment on attachment 230049 [details]
Patch
and more.
Comment on attachment 230049 [details] Patch Rejecting attachment 230049 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 230049, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Andreas Goran Kling found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.appspot.com/results/5649573959696384 Created attachment 230076 [details]
Patch
Comment on attachment 230076 [details]
Patch
Andreas -Goran Kling.
Comment on attachment 230076 [details] Patch Clearing flags on attachment: 230076 Committed r167755: <http://trac.webkit.org/changeset/167755> All reviewed patches have been landed. Closing bug. Not RenderElement? (In reply to comment #16) > Not RenderElement? I need to fix some border painting dependency first in order to be able to move to RenderElement. |