Bug 132037

Summary: Transition RenderTheme API from RenderObject* to const RenderObject&
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, darin, dino, jonlee, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2014-04-22 20:51:41 PDT
ssia. patch is coming up.
Comment 1 zalan 2014-04-23 08:32:22 PDT
Created attachment 229988 [details]
Patch
Comment 2 Andreas Kling 2014-04-23 14:00:33 PDT
This seems like a great thing to be doing, just needs some build fixes. :)
Comment 3 zalan 2014-04-23 20:34:05 PDT
Created attachment 230042 [details]
Patch
Comment 4 zalan 2014-04-23 20:34:26 PDT
Comment on attachment 230042 [details]
Patch

EWSing
Comment 5 zalan 2014-04-23 21:23:43 PDT
Created attachment 230045 [details]
Patch
Comment 6 zalan 2014-04-23 21:23:58 PDT
Comment on attachment 230045 [details]
Patch

more EWS
Comment 7 zalan 2014-04-23 21:49:15 PDT
Created attachment 230048 [details]
Patch
Comment 8 zalan 2014-04-23 21:49:37 PDT
Comment on attachment 230048 [details]
Patch

and some more
Comment 9 zalan 2014-04-23 22:14:05 PDT
Created attachment 230049 [details]
Patch
Comment 10 zalan 2014-04-23 22:14:30 PDT
Comment on attachment 230049 [details]
Patch

and more.
Comment 11 WebKit Commit Bot 2014-04-24 06:48:36 PDT
Comment on attachment 230049 [details]
Patch

Rejecting attachment 230049 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 230049, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Andreas Goran Kling found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5649573959696384
Comment 12 zalan 2014-04-24 06:50:55 PDT
Created attachment 230076 [details]
Patch
Comment 13 zalan 2014-04-24 06:51:45 PDT
Comment on attachment 230076 [details]
Patch

Andreas -Goran Kling.
Comment 14 WebKit Commit Bot 2014-04-24 07:28:26 PDT
Comment on attachment 230076 [details]
Patch

Clearing flags on attachment: 230076

Committed r167755: <http://trac.webkit.org/changeset/167755>
Comment 15 WebKit Commit Bot 2014-04-24 07:28:30 PDT
All reviewed patches have been landed.  Closing bug.
Comment 16 Darin Adler 2014-04-24 07:58:46 PDT
Not RenderElement?
Comment 17 zalan 2014-04-24 08:02:38 PDT
(In reply to comment #16)
> Not RenderElement?
I need to fix some border painting dependency first in order to be able to move to RenderElement.