Bug 132008

Summary:

Subpixel rendering: Clipping on text areas when shifted by one device pixel.

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Patch	none
Patch	none

Description Jon Lee 2014-04-22 10:20:16 PDT

Open the following in snippet editor:

<textarea style="margin-left:0.5px">
</textarea>

The right border is clipped by one device pixel.

Comment 1 Radar WebKit Bug Importer 2014-04-22 10:22:35 PDT

<rdar://problem/16688190>

Comment 2 zalan 2014-04-22 12:32:45 PDT

This is RenderTheme related -> RenderThemeMac::paintTextArea()

Comment 3 zalan 2014-04-23 20:09:23 PDT

Created attachment 230039 [details]
Patch

This patch has source code dependency on bug 132037.

Comment 4 zalan 2014-04-24 08:17:14 PDT

Created attachment 230079 [details]
Patch

Comment 5 Build Bot 2014-04-24 09:15:45 PDT

Comment on attachment 230079 [details]
Patch

Attachment 230079 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6192371926564864

New failing tests:
fast/forms/hidpi-textarea-on-subpixel-position.html

Comment 6 Build Bot 2014-04-24 09:15:48 PDT

Created attachment 230082 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 7 zalan 2014-04-24 09:44:01 PDT

Created attachment 230086 [details]
Patch

Comment 8 zalan 2014-04-24 09:44:20 PDT

Comment on attachment 230086 [details]
Patch

Failure -> ImageOnlyFailure

Comment 9 zalan 2014-04-24 11:09:58 PDT

Created attachment 230092 [details]
Patch

Comment 10 zalan 2014-04-24 11:10:43 PDT

Comment on attachment 230092 [details]
Patch

fix TestExpectations file (remove -expected.html)

Comment 11 WebKit Commit Bot 2014-04-24 13:46:54 PDT

Comment on attachment 230092 [details]
Patch

Clearing flags on attachment: 230092

Committed r167771: <http://trac.webkit.org/changeset/167771>

Comment 12 WebKit Commit Bot 2014-04-24 13:46:58 PDT

All reviewed patches have been landed.  Closing bug.