Bug 132008

Summary: Subpixel rendering: Clipping on text areas when shifted by one device pixel.
Product: WebKit Reporter: Jon Lee <jonlee>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
none
Patch
none
Patch none

Jon Lee
Reported 2014-04-22 10:20:16 PDT
Open the following in snippet editor: <textarea style="margin-left:0.5px"> </textarea> The right border is clipped by one device pixel.
Attachments
Patch (25.05 KB, patch)
2014-04-23 20:09 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (29.09 KB, patch)
2014-04-24 08:17 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (530.18 KB, application/zip)
2014-04-24 09:15 PDT, Build Bot 		no flags
Details
Patch (29.10 KB, patch)
2014-04-24 09:44 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (29.04 KB, patch)
2014-04-24 11:09 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-04-22 10:22:35 PDT
<rdar://problem/16688190>
zalan
Comment 2 2014-04-22 12:32:45 PDT
This is RenderTheme related -> RenderThemeMac::paintTextArea()
zalan
Comment 3 2014-04-23 20:09:23 PDT
Created attachment 230039 [details] Patch This patch has source code dependency on bug 132037.
zalan
Comment 4 2014-04-24 08:17:14 PDT
Created attachment 230079 [details] Patch
Build Bot
Comment 5 2014-04-24 09:15:45 PDT
Comment on attachment 230079 [details] Patch Attachment 230079 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6192371926564864 New failing tests: fast/forms/hidpi-textarea-on-subpixel-position.html
Build Bot
Comment 6 2014-04-24 09:15:48 PDT
Created attachment 230082 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
zalan
Comment 7 2014-04-24 09:44:01 PDT
Created attachment 230086 [details] Patch
zalan
Comment 8 2014-04-24 09:44:20 PDT
Comment on attachment 230086 [details] Patch Failure -> ImageOnlyFailure
zalan
Comment 9 2014-04-24 11:09:58 PDT
Created attachment 230092 [details] Patch
zalan
Comment 10 2014-04-24 11:10:43 PDT
Comment on attachment 230092 [details] Patch fix TestExpectations file (remove -expected.html)
WebKit Commit Bot
Comment 11 2014-04-24 13:46:54 PDT
Comment on attachment 230092 [details] Patch Clearing flags on attachment: 230092 Committed r167771: <http://trac.webkit.org/changeset/167771>
WebKit Commit Bot
Comment 12 2014-04-24 13:46:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.