| Summary: | REGRESSION (r151839): Subframe keeps getting mousemove events with the same coordinates after hiding a hovered element. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||
| Component: | UI Events | Assignee: | Andreas Kling <kling> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, kangil.han, kling | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andreas Kling
2014-04-22 00:57:56 PDT
Created attachment 229868 [details]
Patch
The layout test timeouts are 260ms because the fake mousemove events are sent on 250ms timers. (Urgh.) Created attachment 229870 [details]
Patch
Add a hunk to the ChangeLog about the solution as well..
Comment on attachment 229870 [details]
Patch
Test has some race condition on WK2. Will fixup tomorrow.
Created attachment 229906 [details]
Patch
Okay, here we go again!
Comment on attachment 229906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229906&action=review Make sense. > LayoutTests/fast/events/ghostly-mousemoves-in-subframe.html:75 > + }, 500); Can you use a busy wait here instead of a 0.5s wait? (In reply to comment #6) > (From update of attachment 229906 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=229906&action=review > > Make sense. > > > LayoutTests/fast/events/ghostly-mousemoves-in-subframe.html:75 > > + }, 500); > > Can you use a busy wait here instead of a 0.5s wait? That'd be a bit weird, since I'm waiting for something *not* to happen. I'm gonna land this as-is, if it turns out troublesome, and you're reading this comment in the future wondering what I was thinking, sorry :| Comment on attachment 229906 [details] Patch Clearing flags on attachment: 229906 Committed r167684: <http://trac.webkit.org/changeset/167684> All reviewed patches have been landed. Closing bug. |