Bug 131948

Summary: [GTK] Use the custom buildbot scheduler PlatformSpecificScheduler
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, mrobinson, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch none

Carlos Alberto Lopez Perez
Reported 2014-04-21 13:39:39 PDT
r72111 <http://trac.webkit.org/r72111> added a custom buildbot scheduler that avoids triggering builds for changes that only touch "other-port" files. This scheduler is currently used by the all the Apple bots (both OSX and Win): grep for PlatformSpecificScheduler on file Tools/BuildSlaveSupport/build.webkit.org-config/config.json I think that we should (if needed) patch this scheduler to work also on GTK and switch the GTK bots to it. General documentation about the buildbot schedulers can be found here: http://docs.buildbot.net/0.8.8/manual/cfg-schedulers.html
Attachments
WIP Patch (11.72 KB, patch)
2014-05-12 20:40 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2014-05-12 20:40:32 PDT
Created attachment 231357 [details] WIP Patch
WebKit Commit Bot
Comment 2 2014-05-12 20:43:00 PDT
Attachment 231357 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py:58: missing whitespace after ',' [pep8/E231] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py:51: at least two spaces before inline comment [pep8/E261] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:54: missing whitespace after ',' [pep8/E231] [5] ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:56: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Note You need to log in before you can comment on or make changes to this bug.