Bug 131944

Summary: Need default WKNavigationDelegate behavior
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Anders Carlsson 2014-04-21 12:28:03 PDT 
Need default WKNavigationDelegate behavior
Comment 1 Anders Carlsson 2014-04-21 12:28:31 PDT 
Created attachment 229821 [details]
Patch
Comment 2 mitz 2014-04-21 12:47:29 PDT 
Comment on attachment 229821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229821&action=review

> Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:229
> +#if !PLATFORM(IOS)
> +        if (![nsURLRequest.URL isFileURL])
> +            [[NSWorkspace sharedWorkspace] openURL:nsURLRequest.URL];
> +#endif

This should be #if USE(APPKIT).
Comment 3 Anders Carlsson 2014-04-21 12:51:25 PDT 
Committed r167611: <http://trac.webkit.org/changeset/167611>
Comment 4 Alexey Proskuryakov 2014-04-21 14:37:16 PDT 
Looks like this broke WKNavigation.DidFailProvisionalNavigation: http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20WK1%20(Tests)/builds/4812/steps/run-api-tests/logs/stdio

Note: Google Test filter = WKNavigation.DidFailProvisionalNavigation
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from WKNavigation
[ RUN      ] WKNavigation.DidFailProvisionalNavigation
Timeout
LEAK: 1 WebPage
LEAK: 1 WebFrame