Bug 131926

Summary:

Compile the :root pseudo class and fix a related issue with :nth-child()

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, kangil.han, kling

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Benjamin Poulain 2014-04-20 22:52:17 PDT

Compile the :root pseudo class and fix a related issue with :nth-child()

Comment 1 Benjamin Poulain 2014-04-20 23:01:55 PDT

Created attachment 229789 [details]
Patch

Comment 2 Andreas Kling 2014-04-20 23:15:08 PDT

Comment on attachment 229789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229789&action=review

r=me

I was going to suggest that we add some DRT mechanism to explicitly disable the selector JIT, but I suppose the fact that most ports are building without it means that we are well covered on both code paths for the time being.

> Source/WebCore/cssjit/SelectorCompiler.cpp:1952
> +        // Anything modulo 1 is zero. Unless b restrict the range, this does not filter anything out.

restrict -> restricts

> Source/WebCore/cssjit/SelectorCompiler.cpp:1955
> +        validSubsetFilters.append(slot);

You can use uncheckedAppend() here.

Comment 3 Benjamin Poulain 2014-04-20 23:27:17 PDT

Committed r167585: <http://trac.webkit.org/changeset/167585>