Summary: | REGRESSION (r166784): Gradient at background of iCloud login page doesn’t go all the way to the bottom | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser, zalan | ||||||||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
URL: | https://www.icloud.com | ||||||||||||||
Attachments: |
|
Description
mitz
2014-04-20 22:05:49 PDT
Interestingly, that's a multi device pixel gap. Created attachment 229803 [details]
Test reduction
Apparently LayoutUnit precision is not high enough to calculate scale values for contain/cover. Patch is coming up. Created attachment 229827 [details]
Patch
Comment on attachment 229827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229827&action=review > Source/WebCore/ChangeLog:15 > + revealed that tile size computation gives correct results more often when snapping does not dependw on the location. dependw Comment on attachment 229827 [details] Patch Attachment 229827 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5541439836520448 New failing tests: fast/backgrounds/hidpi-generated-gradient-background-on-subpixel-position.html fast/backgrounds/hidpi-background-image-contain-cover-scale-needs-more-precision.html Created attachment 229834 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 229827 [details] Patch Attachment 229827 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4626646162210816 New failing tests: fast/backgrounds/hidpi-generated-gradient-background-on-subpixel-position.html Created attachment 229835 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 229837 [details]
Patch
Comment on attachment 229837 [details]
Patch
EWS
Comment on attachment 229837 [details] Patch Clearing flags on attachment: 229837 Committed r167637: <http://trac.webkit.org/changeset/167637> All reviewed patches have been landed. Closing bug. |