Bug 131922

Summary: Add Element.matches, the standard name for webkitMatchesSelector
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, cmarcelo, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan, syoichi
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 131929    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2014-04-20 18:09:32 PDT
Add Element.matches, the standard name for webkitMatchesSelector
Attachments
Patch (38.69 KB, patch)
2014-04-20 18:12 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (39.20 KB, patch)
2014-04-21 13:46 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-04-20 18:12:20 PDT
Created attachment 229779 [details] Patch
Andreas Kling
Comment 2 2014-04-20 19:53:00 PDT
Comment on attachment 229779 [details] Patch Nice. r=me
Benjamin Poulain
Comment 3 2014-04-20 23:08:33 PDT
Comment on attachment 229779 [details] Patch Clearing flags on attachment: 229779 Committed r167584: <http://trac.webkit.org/changeset/167584>
Benjamin Poulain
Comment 4 2014-04-20 23:08:43 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2014-04-21 00:04:32 PDT
This somehow broke Objective-C bindings generation. Ben, are you around to take a look? http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20(Tests)/builds/5357/steps/bindings-generation-tests/logs/stdio
WebKit Commit Bot
Comment 6 2014-04-21 00:22:56 PDT
Re-opened since this is blocked by bug 131929
Alexey Proskuryakov
Comment 7 2014-04-21 00:26:27 PDT
Rolled out in <https://trac.webkit.org/r167588>. The diff was: - (void)orange { WebCore::JSMainThreadNullState state; - IMPL->orange(); + IMPL->banana(); }
Benjamin Poulain
Comment 8 2014-04-21 13:46:41 PDT
Created attachment 229830 [details] Patch
Benjamin Poulain
Comment 9 2014-04-21 15:26:17 PDT
Committed r167631: <http://trac.webkit.org/changeset/167631>
Note You need to log in before you can comment on or make changes to this bug.