Bug 131916

Summary:

iOS and non-iOS RemoteCommandListener::create() functions should use std::make_unique<>()

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Zan Dobersek 2014-04-20 11:01:56 PDT

iOS and non-iOS RemoteCommandListener::create() functions should use std::make_unique<>()

Comment 1 Zan Dobersek 2014-04-20 11:07:11 PDT

Created attachment 229770 [details]
Patch

Comment 2 Darin Adler 2014-04-20 19:45:57 PDT

Comment on attachment 229770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229770&action=review

I guess this is OK. It does seem slightly unsafe that the constructor is public given that it would be incorrect to use it on iOS, but still better than a “naked new”.

> Source/WebCore/platform/RemoteCommandListener.h:42
> +    RemoteCommandListener(RemoteCommandListenerClient& client) : m_client(client) { };

No semicolon needed.

Comment 3 Zan Dobersek 2014-04-21 03:49:41 PDT

Committed r167590: <http://trac.webkit.org/changeset/167590>