Bug 131916

Summary: iOS and non-iOS RemoteCommandListener::create() functions should use std::make_unique<>()
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Zan Dobersek
Reported 2014-04-20 11:01:56 PDT
iOS and non-iOS RemoteCommandListener::create() functions should use std::make_unique<>()
Attachments
Patch (2.99 KB, patch)
2014-04-20 11:07 PDT, Zan Dobersek 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-04-20 11:07:11 PDT
Created attachment 229770 [details] Patch
Darin Adler
Comment 2 2014-04-20 19:45:57 PDT
Comment on attachment 229770 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229770&action=review I guess this is OK. It does seem slightly unsafe that the constructor is public given that it would be incorrect to use it on iOS, but still better than a “naked new”. > Source/WebCore/platform/RemoteCommandListener.h:42 > + RemoteCommandListener(RemoteCommandListenerClient& client) : m_client(client) { }; No semicolon needed.
Zan Dobersek
Comment 3 2014-04-21 03:49:41 PDT
Committed r167590: <http://trac.webkit.org/changeset/167590>
Note You need to log in before you can comment on or make changes to this bug.