Bug 131911

Summary:

[GTK] YCM choose a newer compile_commands.json in between Release or Debug

Product:

WebKit

Reporter:

ChangSeok Oh <changseok>

Component:

WebKitGTK

Assignee:

ChangSeok Oh <changseok>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, commit-queue, gustavo, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mrobinson: review+, mrobinson: commit-queue-
Patch	commit-queue: commit-queue-
Patch	none

ChangSeok Oh

Reported 2014-04-20 02:50:40 PDT

SSIA.

Attachments
Patch (2.51 KB, patch) 2014-04-20 03:05 PDT, ChangSeok Oh	no flags	Details Formatted Diff Diff
Patch (2.45 KB, patch) 2014-04-21 08:11 PDT, ChangSeok Oh	mrobinson: review+ mrobinson: commit-queue-	Details Formatted Diff Diff
Patch (2.42 KB, patch) 2014-04-22 09:02 PDT, ChangSeok Oh	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch (2.41 KB, patch) 2014-04-22 09:18 PDT, ChangSeok Oh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

ChangSeok Oh

Comment 1 2014-04-20 03:05:39 PDT

Created attachment 229760 [details] Patch

Martin Robinson

Comment 2 2014-04-20 05:12:00 PDT

Comment on attachment 229760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229760&action=review > Tools/gtk/ycm_extra_conf.py:80 > + return release_build_path if release_mtime - debug_mtime >= 0 else debug_build_path Can't this just be release_time >= debug_mtime?

ChangSeok Oh

Comment 3 2014-04-21 08:11:04 PDT

Comment on attachment 229760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229760&action=review >> Tools/gtk/ycm_extra_conf.py:80 >> + return release_build_path if release_mtime - debug_mtime >= 0 else debug_build_path > > Can't this just be release_time >= debug_mtime? Why not? Nothing different :)

ChangSeok Oh

Comment 4 2014-04-21 08:11:37 PDT

Created attachment 229801 [details] Patch

Martin Robinson

Comment 5 2014-04-21 18:42:28 PDT

Comment on attachment 229801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229801&action=review > Tools/gtk/ycm_extra_conf.py:111 > + webkitbuild_path = os.path.join(common.get_build_path(fatal=False), '..') > + build_path = os.path.normpath(get_build_path(webkitbuild_path)) I don't think this needs to be an argument to get_build_path. Instead I think that get_build_path can call common.get_build_path itself.

ChangSeok Oh

Comment 6 2014-04-22 09:02:39 PDT

Created attachment 229885 [details] Patch

ChangSeok Oh

Comment 7 2014-04-22 09:03:19 PDT

Comment on attachment 229801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229801&action=review >> Tools/gtk/ycm_extra_conf.py:111 >> + build_path = os.path.normpath(get_build_path(webkitbuild_path)) > > I don't think this needs to be an argument to get_build_path. Instead I think that get_build_path can call common.get_build_path itself. O.K!

WebKit Commit Bot

Comment 8 2014-04-22 09:11:08 PDT

Comment on attachment 229885 [details] Patch Rejecting attachment 229885 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 229885, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5157295277211648

ChangSeok Oh

Comment 9 2014-04-22 09:18:06 PDT

Created attachment 229886 [details] Patch

ChangSeok Oh

Comment 10 2014-04-22 09:20:13 PDT

Comment on attachment 229886 [details] Patch Got r+ before. See above.

WebKit Commit Bot

Comment 11 2014-04-22 10:38:45 PDT

Comment on attachment 229886 [details] Patch Clearing flags on attachment: 229886 Committed r167667: <http://trac.webkit.org/changeset/167667>

ChangSeok Oh

Comment 12 2016-04-06 21:38:46 PDT

Patch landed. Close the ticket.

Note You need to log in before you can comment on or make changes to this bug.