Bug 131911

Summary: [GTK] YCM choose a newer compile_commands.json in between Release or Debug
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: WebKitGTKAssignee: ChangSeok Oh <changseok>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
mrobinson: review+, mrobinson: commit-queue-
Patch
commit-queue: commit-queue-
Patch none

Description ChangSeok Oh 2014-04-20 02:50:40 PDT 
SSIA.
Comment 1 ChangSeok Oh 2014-04-20 03:05:39 PDT 
Created attachment 229760 [details]
Patch
Comment 2 Martin Robinson 2014-04-20 05:12:00 PDT 
Comment on attachment 229760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229760&action=review

> Tools/gtk/ycm_extra_conf.py:80
> +    return release_build_path if release_mtime - debug_mtime >= 0 else debug_build_path

Can't this just be release_time >= debug_mtime?
Comment 3 ChangSeok Oh 2014-04-21 08:11:04 PDT 
Comment on attachment 229760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229760&action=review

>> Tools/gtk/ycm_extra_conf.py:80
>> +    return release_build_path if release_mtime - debug_mtime >= 0 else debug_build_path
> 
> Can't this just be release_time >= debug_mtime?

Why not? Nothing different :)
Comment 4 ChangSeok Oh 2014-04-21 08:11:37 PDT 
Created attachment 229801 [details]
Patch
Comment 5 Martin Robinson 2014-04-21 18:42:28 PDT 
Comment on attachment 229801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229801&action=review

> Tools/gtk/ycm_extra_conf.py:111
> +    webkitbuild_path = os.path.join(common.get_build_path(fatal=False), '..')
> +    build_path = os.path.normpath(get_build_path(webkitbuild_path))

I don't think this needs to be an argument to get_build_path. Instead I think that get_build_path can call common.get_build_path itself.
Comment 6 ChangSeok Oh 2014-04-22 09:02:39 PDT 
Created attachment 229885 [details]
Patch
Comment 7 ChangSeok Oh 2014-04-22 09:03:19 PDT 
Comment on attachment 229801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229801&action=review

>> Tools/gtk/ycm_extra_conf.py:111
>> +    build_path = os.path.normpath(get_build_path(webkitbuild_path))
> 
> I don't think this needs to be an argument to get_build_path. Instead I think that get_build_path can call common.get_build_path itself.

O.K!
Comment 8 WebKit Commit Bot 2014-04-22 09:11:08 PDT 
Comment on attachment 229885 [details]
Patch

Rejecting attachment 229885 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 229885, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5157295277211648
Comment 9 ChangSeok Oh 2014-04-22 09:18:06 PDT 
Created attachment 229886 [details]
Patch
Comment 10 ChangSeok Oh 2014-04-22 09:20:13 PDT 
Comment on attachment 229886 [details]
Patch

Got r+ before. See above.
Comment 11 WebKit Commit Bot 2014-04-22 10:38:45 PDT 
Comment on attachment 229886 [details]
Patch

Clearing flags on attachment: 229886

Committed r167667: <http://trac.webkit.org/changeset/167667>
Comment 12 ChangSeok Oh 2016-04-06 21:38:46 PDT 
Patch landed. Close the ticket.