Bug 131881
| Summary: | REGRESSION (r167530): fast/dom/gc-attribute-node.html is failing on Mac | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | ap, fpizlo, ggaren, mhahnenberg, oliver |
| Priority: | P2 | Keywords: | LayoutTestFailure, PlatformOnly |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Timothy Hatcher
It has been failing on Windows (bug 127480).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Timothy Hatcher
Marked as flaky in https://trac.webkit.org/r167531.
Alexey Proskuryakov
Could you please post a diff? Looking at flakiness dashboard, I don't see this test having ever failed.
Timothy Hatcher
It started flaking with my patch in https://trac.webkit.org/r167530. Not really sure why. My change is unrelated to the tested code.
Alexey Proskuryakov
Could be memory corruption from
Timothy Hatcher
From?
Alexey Proskuryakov
I wanted to conjecture memory corruption from a previous test, but that's not accurate.
Turns out that custom attributes on attribute nodes are broken in JSC. We used to know that and to expect a failure, until Filip's patch <http://trac.webkit.org/changeset/159705> slightly changed memory layout, so the test started to pass accidentally. He then removed the failing expectation.
But there was no real fix, and now your patch slightly changed memory layout again, making the test fail again.
*** This bug has been marked as a duplicate of bug 88045 ***