Bug 131878 – Fix AVPlayerController leak on pages with video

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Joseph Pecoraro]

I was seeing leaks of an AVPlayerController allocated with this stack:

        ...
        | WebKit::WebContext::createWebPage(WebKit::PageClient&, WebKit::WebPageConfiguration)
        | WebKit::WebProcessProxy::createWebPage(WebKit::PageClient&, WebKit::WebPageConfiguration const&)
        | WebKit::WebPageProxy::create(WebKit::PageClient&, WebKit::WebProcessProxy&, unsigned long long, WebKit::WebPageConfiguration const&)
        | WebKit::WebPageProxy::WebPageProxy(WebKit::PageClient&, WebKit::WebProcessProxy&, unsigned long long, WebKit::WebPageConfiguration const&)
        | WebKit::WebVideoFullscreenManagerProxy::create(WebKit::WebPageProxy&)
        | WebKit::WebVideoFullscreenManagerProxy::WebVideoFullscreenManagerProxy(WebKit::WebPageProxy&)
        | WebCore::WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel(WebCore::WebVideoFullscreenModel*)
        | -[WebAVPlayerController init]
        | _objc_rootAlloc
        | class_createInstance
        | calloc
        | malloc_zone_calloc 

The allocation was:

    self.playerControllerProxy = [[classAVPlayerController alloc] init];

This is a (retain) property which will +1 the incoming object, so the alloc/init needs to be balanced.

[Joseph Pecoraro]

Created attachment 229711 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 229711 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 229711

Committed r167551: <http://trac.webkit.org/changeset/167551>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.