Bug 131785

Summary:

Add separate flag for IndexedDatabase in workers since the current implementation is not threadsafe

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

New Bugs

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, benjamin, buildbot, cdumez, cmarcelo, commit-queue, esprehn+autocc, jsbell, kondapallykalyan, rniwa

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion	none
Patch	none

Darin Adler

Reported 2014-04-16 20:33:33 PDT

Add separate flag for IndexedDatabase in workers since the current implementation is not threadsafe

Attachments
Patch (32.56 KB, patch) 2014-04-16 20:35 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (479.73 KB, application/zip) 2014-04-16 23:07 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (513.26 KB, application/zip) 2014-04-16 23:53 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (530.85 KB, application/zip) 2014-04-17 00:06 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (508.89 KB, application/zip) 2014-04-17 00:40 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (537.24 KB, application/zip) 2014-04-17 01:43 PDT, Build Bot	no flags	Details
Patch (32.82 KB, patch) 2014-04-17 07:44 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2014-04-16 20:35:40 PDT

Created attachment 229518 [details] Patch

Brady Eidson

Comment 2 2014-04-16 21:22:49 PDT

Comment on attachment 229518 [details] Patch As long as it builds, the approach seems great!

Build Bot

Comment 3 2014-04-16 23:07:11 PDT

Comment on attachment 229518 [details] Patch Attachment 229518 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5659914361896960 New failing tests: js/dom/global-constructors-attributes-shared-worker.html js/dom/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 4 2014-04-16 23:07:17 PDT

Created attachment 229524 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2014-04-16 23:53:19 PDT

Comment on attachment 229518 [details] Patch Attachment 229518 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5329672128692224 New failing tests: js/dom/global-constructors-attributes-shared-worker.html js/dom/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 6 2014-04-16 23:53:23 PDT

Created attachment 229526 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-04-17 00:06:12 PDT

Comment on attachment 229518 [details] Patch Attachment 229518 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5275488968769536 New failing tests: js/dom/global-constructors-attributes-shared-worker.html js/dom/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 8 2014-04-17 00:06:17 PDT

Created attachment 229527 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 9 2014-04-17 00:40:34 PDT

Comment on attachment 229518 [details] Patch Attachment 229518 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6728687932145664 New failing tests: js/dom/global-constructors-attributes-shared-worker.html js/dom/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 10 2014-04-17 00:40:38 PDT

Created attachment 229529 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 11 2014-04-17 01:43:46 PDT

Comment on attachment 229518 [details] Patch Attachment 229518 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4671978954817536 New failing tests: js/dom/global-constructors-attributes-shared-worker.html js/dom/global-constructors-attributes-dedicated-worker.html

Build Bot

Comment 12 2014-04-17 01:43:51 PDT

Created attachment 229532 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Darin Adler

Comment 13 2014-04-17 07:44:45 PDT

Created attachment 229544 [details] Patch

Darin Adler

Comment 14 2014-04-17 07:48:45 PDT

Committed r167427: <http://trac.webkit.org/changeset/167427>

Darin Adler

Comment 15 2014-04-17 08:39:46 PDT

<rdar://problem/16003108>

Darin Adler

Comment 16 2014-04-17 09:55:53 PDT

This seems to have broken the EFL build although the GTK build is fine.

Darin Adler

Comment 17 2014-04-17 09:56:54 PDT

I’m guessing it’s because the CMake version of the build rules doesn’t have correct dependencies for the Modules machinery. Best way to fix it would be migrating to DerivedSources.make instead, but we can probably work around it just by touching the main IDL file. (All just a guess.)

Note You need to log in before you can comment on or make changes to this bug.