Summary: | Get SharedBuffer.h out of ResourceBuffer.h (and a few other places) | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Pratik Solanki <psolanki> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | alecflett, andersca, commit-queue, japhet, jsbell, psolanki, sam, simon.fraser | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Tim Horton
2014-04-16 19:41:43 PDT
Created attachment 229514 [details]
patch
Attachment 229514 [details] did not pass style-queue:
ERROR: Source/WebCore/loader/ResourceBuffer.h:48: The parameter name "shared" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 235580 [details]
Updated Tim's patch for the bots
Attachment 235580 [details] did not pass style-queue:
ERROR: Source/WebCore/loader/ResourceBuffer.h:48: The parameter name "shared" adds no information, so it should be removed. [readability/parameter_name] [5]
ERROR: Source/WebCore/loader/cache/MemoryCache.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 235627 [details]
Take 2
Created attachment 235641 [details]
Take 3 - fixes for gtk
Created attachment 235652 [details]
Patch for review
Updated Tim's original patch to make it compile on gtk and iOS.
Comment on attachment 235652 [details] Patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=235652&action=review > Source/WebCore/Modules/indexeddb/IDBCallbacks.h:44 > class IDBDatabaseBackend; > - > +class SharedBuffer; > struct IDBDatabaseMetadata; Why delete the blank line between the classes and the struct? Committed r171743: <http://trac.webkit.org/changeset/171743> |