Bug 131782

Summary:

Get SharedBuffer.h out of ResourceBuffer.h (and a few other places)

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebCore Misc.

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, andersca, commit-queue, japhet, jsbell, psolanki, sam, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	simon.fraser: review+
Updated Tim's patch for the bots	none
Take 2	none
Take 3 - fixes for gtk	none
Patch for review	darin: review+

Tim Horton

Reported 2014-04-16 19:41:43 PDT

Speeds.

Attachments
patch (22.76 KB, patch) 2014-04-16 19:55 PDT, Tim Horton	simon.fraser: review+	Details Formatted Diff Diff
Updated Tim's patch for the bots (16.59 KB, patch) 2014-07-26 21:34 PDT, Pratik Solanki	no flags	Details Formatted Diff Diff
Take 2 (11.46 KB, patch) 2014-07-28 15:55 PDT, Pratik Solanki	no flags	Details Formatted Diff Diff
Take 3 - fixes for gtk (11.48 KB, patch) 2014-07-28 16:54 PDT, Pratik Solanki	no flags	Details Formatted Diff Diff
Patch for review (15.37 KB, patch) 2014-07-28 17:33 PDT, Pratik Solanki	darin: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2014-04-16 19:55:17 PDT

Created attachment 229514 [details] patch

WebKit Commit Bot

Comment 2 2014-04-16 19:57:21 PDT

Attachment 229514 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ResourceBuffer.h:48: The parameter name "shared" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Pratik Solanki

Comment 3 2014-07-26 21:34:43 PDT

Created attachment 235580 [details] Updated Tim's patch for the bots

WebKit Commit Bot

Comment 4 2014-07-26 21:35:48 PDT

Attachment 235580 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ResourceBuffer.h:48: The parameter name "shared" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/loader/cache/MemoryCache.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.

Pratik Solanki

Comment 5 2014-07-28 15:55:11 PDT

Created attachment 235627 [details] Take 2

Pratik Solanki

Comment 6 2014-07-28 16:54:09 PDT

Created attachment 235641 [details] Take 3 - fixes for gtk

Pratik Solanki

Comment 7 2014-07-28 17:33:18 PDT

Created attachment 235652 [details] Patch for review Updated Tim's original patch to make it compile on gtk and iOS.

Darin Adler

Comment 8 2014-07-29 00:36:11 PDT

Comment on attachment 235652 [details] Patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=235652&action=review > Source/WebCore/Modules/indexeddb/IDBCallbacks.h:44 > class IDBDatabaseBackend; > - > +class SharedBuffer; > struct IDBDatabaseMetadata; Why delete the blank line between the classes and the struct?

Pratik Solanki

Comment 9 2014-07-29 07:35:45 PDT

Committed r171743: <http://trac.webkit.org/changeset/171743>

Note You need to log in before you can comment on or make changes to this bug.