Bug 131756

Summary:

Fix CodeGenerator.pm to only write files if the generated content has changed

Product:

WebKit

Reporter:

Bem Jones-Bey <bjonesbe>

Component:

Tools / Tests

Assignee:

Bem Jones-Bey <bjonesbe>

Status:

RESOLVED LATER

Severity:

Normal

CC:

ap, cdumez, cgarcia, commit-queue, Hironori.Fujii, mjs, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Bem Jones-Bey

Reported 2014-04-16 13:39:05 PDT

Fix CodeGenerator.pm to only write files if the generated content has changed

Attachments
Patch (1.74 KB, patch) 2014-04-16 13:41 PDT, Bem Jones-Bey	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Bem Jones-Bey

Comment 1 2014-04-16 13:41:32 PDT

Created attachment 229475 [details] Patch

Sam Weinig

Comment 2 2014-04-16 13:42:49 PDT

Comment on attachment 229475 [details] Patch Sweet!

WebKit Commit Bot

Comment 3 2014-04-16 14:14:52 PDT

Comment on attachment 229475 [details] Patch Clearing flags on attachment: 229475 Committed r167384: <http://trac.webkit.org/changeset/167384>

WebKit Commit Bot

Comment 4 2014-04-16 14:14:56 PDT

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 5 2014-04-17 09:38:44 PDT

I thought that we decided against this approach several times before, because it means that input files will always be newer than the outputs, so we will be running CodeGenerator.pm on most inputs every time. Am I missing something?

Bem Jones-Bey

Comment 6 2014-04-17 11:31:10 PDT

(In reply to comment #5) > I thought that we decided against this approach several times before, because it means that input files will always be newer than the outputs, so we will be running CodeGenerator.pm on most inputs every time. > > Am I missing something? You're right, that is a problem with this change. I believe I can fix that problem, however. I'll work on a fix for that today.

Bem Jones-Bey

Comment 7 2014-04-17 15:11:22 PDT

(In reply to comment #6) > (In reply to comment #5) > > I thought that we decided against this approach several times before, because it means that input files will always be newer than the outputs, so we will be running CodeGenerator.pm on most inputs every time. > > > > Am I missing something? > > You're right, that is a problem with this change. I believe I can fix that problem, however. I'll work on a fix for that today. I have a fix for the Mac build in Bug 131820.

Bem Jones-Bey

Comment 8 2014-04-17 18:05:50 PDT

Reverted r167384 for reason: Sounds like this isn't the right fix, and causes generation to run far too often. Committed r167474: <http://trac.webkit.org/changeset/167474>

Bem Jones-Bey

Comment 9 2014-04-28 17:30:31 PDT

I have no brilliant ideas on fixing this in the near term, so closing for now.

Fujii Hironori

Comment 10 2016-11-10 19:03:07 PST

generate-bindings-all.pl solves the original problem in a different approach. * Bug 161433 – [CMake] CMake does not support the dep files for implicit dependency * Bug 164054 – generate-bindings-all.pl should recompile supplemented IDL if its supplemental IDL are added or removed * Bug 164121 – [CMake] Changing enabled features should trigger recompiling all IDL

Note You need to log in before you can comment on or make changes to this bug.