Bug 131754

Summary: Remove DynamicAnnotations.h?
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bunhere, cmarcelo, commit-queue, ddkilzer, dfarler, gyuyoung.kim, kling, mrobinson, rakuco, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2014-04-16 13:00:13 PDT
Not sure that any platform defines USE_DYNAMIC_ANNOTATIONS, but DynamicAnnotations.h is included in many WebCore source files via ThreadSafeRefCounted, so we should remove it if we can.
Attachments
Patch (16.42 KB, patch)
2014-04-17 09:07 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (16.99 KB, patch)
2014-04-17 10:42 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-04-17 08:57:03 PDT
I also think this looks safe to remove.
Martin Robinson
Comment 2 2014-04-17 09:03:01 PDT
Although, it does seem that this is the kid of thing that someone might turn on as an option for debugging an issue. I'll send a quick note to webkit-dev to see if anyone is using it.
Martin Robinson
Comment 3 2014-04-17 09:07:32 PDT
Created attachment 229551 [details] Patch
Martin Robinson
Comment 4 2014-04-17 10:42:19 PDT
Created attachment 229556 [details] Patch
Simon Fraser (smfr)
Comment 5 2014-04-18 11:08:03 PDT
No feedback on webkit-dev. I think you can go ahead and commit this.
Martin Robinson
Comment 6 2014-04-18 14:03:56 PDT
Comment on attachment 229556 [details] Patch Clearing flags on attachment: 229556 Committed r167508: <http://trac.webkit.org/changeset/167508>
Martin Robinson
Comment 7 2014-04-18 14:04:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.