Bug 131751

Summary:

Log number of bytes reclaimed at each step of memory pressure relief.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Platform

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+
Patch for landing	commit-queue: commit-queue-
Patch for landing	none

Andreas Kling

Reported 2014-04-16 11:52:03 PDT

Memory pressure relief should be more talkative.

Attachments
Patch (7.65 KB, patch) 2014-04-16 11:53 PDT, Andreas Kling	koivisto: review+	Details Formatted Diff Diff
Patch for landing (7.65 KB, patch) 2014-04-17 11:37 PDT, Andreas Kling	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for landing (7.77 KB, patch) 2014-04-17 11:43 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2014-04-16 11:53:47 PDT

Created attachment 229462 [details] Patch

Antti Koivisto

Comment 2 2014-04-16 11:59:05 PDT

Comment on attachment 229462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229462&action=review > Source/WebCore/platform/MemoryPressureHandler.h:49 > +class ReliefLogger { I think should either be in MemoryPressureHandler scope or should be called something less generic like MemoryPressureReliefLogger

Andreas Kling

Comment 3 2014-04-17 11:37:24 PDT

Created attachment 229565 [details] Patch for landing

WebKit Commit Bot

Comment 4 2014-04-17 11:38:46 PDT

Comment on attachment 229565 [details] Patch for landing Rejecting attachment 229565 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 229565, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5026595664297984

Andreas Kling

Comment 5 2014-04-17 11:43:16 PDT

Created attachment 229566 [details] Patch for landing

WebKit Commit Bot

Comment 6 2014-04-17 12:20:25 PDT

Comment on attachment 229566 [details] Patch for landing Clearing flags on attachment: 229566 Committed r167445: <http://trac.webkit.org/changeset/167445>

WebKit Commit Bot

Comment 7 2014-04-17 12:20:28 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.