Bug 131751

Summary: Log number of bytes reclaimed at each step of memory pressure relief.
Product: WebKit Reporter: Andreas Kling <kling>
Component: PlatformAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+
Patch for landing
commit-queue: commit-queue-
Patch for landing none

Description Andreas Kling 2014-04-16 11:52:03 PDT
Memory pressure relief should be more talkative.
Comment 1 Andreas Kling 2014-04-16 11:53:47 PDT
Created attachment 229462 [details]
Patch
Comment 2 Antti Koivisto 2014-04-16 11:59:05 PDT
Comment on attachment 229462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229462&action=review

> Source/WebCore/platform/MemoryPressureHandler.h:49
> +class ReliefLogger {

I think should either be in MemoryPressureHandler scope or should be called something less generic like MemoryPressureReliefLogger
Comment 3 Andreas Kling 2014-04-17 11:37:24 PDT
Created attachment 229565 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2014-04-17 11:38:46 PDT
Comment on attachment 229565 [details]
Patch for landing

Rejecting attachment 229565 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 229565, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5026595664297984
Comment 5 Andreas Kling 2014-04-17 11:43:16 PDT
Created attachment 229566 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2014-04-17 12:20:25 PDT
Comment on attachment 229566 [details]
Patch for landing

Clearing flags on attachment: 229566

Committed r167445: <http://trac.webkit.org/changeset/167445>
Comment 7 WebKit Commit Bot 2014-04-17 12:20:28 PDT
All reviewed patches have been landed.  Closing bug.