Bug 131743

Summary: Unreviewed, ARMv7 buildfix after r167336.
Product: WebKit Reporter: Adrian Perez <aperez>
Component: New BugsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, ossy, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review-

Adrian Perez
Reported 2014-04-16 10:45:06 PDT
Unreviewed, ARMv7 buildfix after r167336.
Attachments
Patch (1.43 KB, patch)
2014-04-16 10:46 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch (1.45 KB, patch)
2014-04-17 09:09 PDT, Adrian Perez 		ggaren: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2014-04-16 10:46:19 PDT
Created attachment 229457 [details] Patch
Adrian Perez
Comment 2 2014-04-17 07:08:13 PDT
The patch does not fix the build, build log: In file included from ../../Source/JavaScriptCore/assembler/MacroAssembler.h:32:0, from ../../Source/JavaScriptCore/jit/GPRInfo.h:29, from ../../Source/JavaScriptCore/bytecode/ValueRecovery.h:31, from ../../Source/JavaScriptCore/bytecode/CodeOrigin.h:32, from ../../Source/JavaScriptCore/jit/ClosureCallStubRoutine.h:31, from ../../Source/JavaScriptCore/bytecode/CallLinkInfo.h:29, from ../../Source/JavaScriptCore/bytecode/CodeBlock.h:37, from ../../Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:29: ../../Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1522:10: error: ‘JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump JSC::MacroAssemblerARMv7::branchAdd32(JSC::MacroAssemblerARMv7::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Address, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::RegisterID)’ cannot be overloaded Jump branchAdd32(ResultCondition cond, Address src, RegisterID dest) ^ ../../Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1511:10: error: with ‘JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump JSC::MacroAssemblerARMv7::branchAdd32(JSC::MacroAssemblerARMv7::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Address, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::RegisterID)’ Jump branchAdd32(ResultCondition cond, Address src, RegisterID dest) ^ ../../Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h: In member function ‘JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Jump JSC::MacroAssemblerARMv7::branchAdd32(JSC::MacroAssemblerARMv7::ResultCondition, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Address, JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::RegisterID)’: ../../Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1513:62: error: ‘getCachedDataTempRegisterIDAndInvalidate’ was not declared in this scope load32(src, getCachedDataTempRegisterIDAndInvalidate()); ^ [6/5048] cd /webkit/gtk-linux-arm-release/build/WebKitBuild/Release/Tools/T...arm-release/build/WebKitBuild/Release/DerivedSources/ForwardingHeaders soup ninja: build stopped: subcommand failed.
Adrian Perez
Comment 3 2014-04-17 09:09:49 PDT
Created attachment 229552 [details] Patch
Geoffrey Garen
Comment 4 2014-04-17 13:06:12 PDT
Comment on attachment 229552 [details] Patch This is out-of-date.
Zan Dobersek
Comment 5 2014-07-29 05:16:36 PDT
Is this still valid?
Csaba Osztrogonác
Comment 6 2014-07-29 05:21:42 PDT
(In reply to comment #5) > Is this still valid? no, fix was landed in https://trac.webkit.org/changeset/167354
Note You need to log in before you can comment on or make changes to this bug.