Bug 131722

Summary:

[iOS][WK2] Fix annoying scrolling bugs

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Benjamin Poulain 2014-04-15 22:15:01 PDT

[iOS][WK2] Fix annoying scrolling bugs

Comment 1 Benjamin Poulain 2014-04-15 22:17:42 PDT

Created attachment 229430 [details]
Patch

Comment 2 Simon Fraser (smfr) 2014-04-15 23:01:29 PDT

Comment on attachment 229430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229430&action=review

Thanks for fixing!

> Source/WebCore/ChangeLog:11
> +        keep changing the scroll position to incorrect values.

Why does it compute incorrect values?

Comment 3 Simon Fraser (smfr) 2014-04-16 10:43:34 PDT

Comment on attachment 229430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=229430&action=review

> Source/WebCore/platform/ScrollView.cpp:545
> +#if PLATFORM(IOS)
> +    UNUSED_PARAM(desiredOffset);
> +    return;
> +#else

Afterthought: should this be if delegatesScrolling() rather than an #ifdef?

Comment 4 Benjamin Poulain 2014-04-16 20:27:23 PDT

Committed r167411: <http://trac.webkit.org/changeset/167411>