Bug 131699

Summary: Simple ES6 feature: Array.of
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Oliver Hunt <oliver>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: buildbot, dpino, joepeck, m.goleb+bugzilla, rniwa, webkit-bug-importer
Priority: P2 Keywords: EasyFix, InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ggaren: review+
Patch
none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
none
Patch none

Oliver Hunt
Reported 2014-04-15 14:57:02 PDT
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-22.1.2.3 Should be doable in builtin JS
Attachments
Patch (11.55 KB, patch)
2014-04-18 16:41 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
Patch (14.48 KB, patch)
2014-10-04 09:11 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (515.89 KB, application/zip)
2014-10-04 10:13 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (800.86 KB, application/zip)
2014-10-04 11:09 PDT, Build Bot 		no flags
Details
Patch (18.27 KB, patch)
2014-10-04 11:46 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-04-15 14:57:21 PDT
<rdar://problem/16625973>
Oliver Hunt
Comment 2 2014-04-18 16:41:06 PDT
Created attachment 229683 [details] Patch
Geoffrey Garen
Comment 3 2014-04-18 16:56:47 PDT
Comment on attachment 229683 [details] Patch r=me
Diego Pino
Comment 4 2014-10-04 09:11:03 PDT
Created attachment 239281 [details] Patch
Diego Pino
Comment 5 2014-10-04 09:13:07 PDT
I added more tests to the patch. I imported the Array.of tests from Mozilla and modified the implementation of Array.of() in order to pass the tests.
Build Bot
Comment 6 2014-10-04 10:13:48 PDT
Comment on attachment 239281 [details] Patch Attachment 239281 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5841998703493120 New failing tests: js/Object-getOwnPropertyNames.html
Build Bot
Comment 7 2014-10-04 10:13:51 PDT
Created attachment 239282 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 8 2014-10-04 11:09:14 PDT
Comment on attachment 239281 [details] Patch Attachment 239281 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4617453329973248 New failing tests: js/Object-getOwnPropertyNames.html
Build Bot
Comment 9 2014-10-04 11:09:18 PDT
Created attachment 239283 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Diego Pino
Comment 10 2014-10-04 11:46:58 PDT
Created attachment 239284 [details] Patch
Joseph Pecoraro
Comment 11 2015-11-12 21:54:11 PST
Comment on attachment 239284 [details] Patch Clearing review flag. This patch seems stale as Array.of seems to have already landed as part of: https://bugs.webkit.org/show_bug.cgi?id=140605 https://bugs.webkit.org/show_bug.cgi?id=145365 That said, the tests in this bug seem valuable. It may be worth creating a new bug + patch to add extra testing for Array.of.
Joseph Pecoraro
Comment 12 2015-11-12 21:54:28 PST
*** This bug has been marked as a duplicate of bug 140605 ***
Note You need to log in before you can comment on or make changes to this bug.