| Summary: | Simple ES6 feature: Array.of | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||||||||
| Component: | JavaScriptCore | Assignee: | Oliver Hunt <oliver> | ||||||||||||
| Status: | RESOLVED DUPLICATE | ||||||||||||||
| Severity: | Normal | CC: | buildbot, dpino, joepeck, m.goleb+bugzilla, rniwa, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | EasyFix, InRadar | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Oliver Hunt
2014-04-15 14:57:02 PDT
Created attachment 229683 [details]
Patch
Comment on attachment 229683 [details]
Patch
r=me
Created attachment 239281 [details]
Patch
I added more tests to the patch. I imported the Array.of tests from Mozilla and modified the implementation of Array.of() in order to pass the tests. Comment on attachment 239281 [details] Patch Attachment 239281 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5841998703493120 New failing tests: js/Object-getOwnPropertyNames.html Created attachment 239282 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 239281 [details] Patch Attachment 239281 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4617453329973248 New failing tests: js/Object-getOwnPropertyNames.html Created attachment 239283 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 239284 [details]
Patch
Comment on attachment 239284 [details] Patch Clearing review flag. This patch seems stale as Array.of seems to have already landed as part of: https://bugs.webkit.org/show_bug.cgi?id=140605 https://bugs.webkit.org/show_bug.cgi?id=145365 That said, the tests in this bug seem valuable. It may be worth creating a new bug + patch to add extra testing for Array.of. *** This bug has been marked as a duplicate of bug 140605 *** |