Move DOM timer throttling out of the page throttler

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Stephanie Lewis]

Created attachment 229405 [details]
patch

DOM timer throttling is currently part of the page throttler which uses per process state and per page state to determine when to throttle.  This led us to being overly conservative when turning DOM throttling off.  It should only respond to view state changes.

Additionally since creating extra Page Throttlers for WebKit1 views and SVG images caused bugs in tracking state we'll reserve the Page Throttler for WebKit2 views.  To avoid regressing we should move DOM timer throttling back to the page.

<rdar://problem/16473004> Throttling DOM timers should be per-page, not per-process

[Darin Adler]

Comment on attachment 229405 [details]
patch

Patch didn’t apply. Could you post a new one that is rebased so it does apply?

[Stephanie Lewis]

Created attachment 229501 [details]
rebased patch

[Stephanie Lewis]

Created attachment 229503 [details]
rebased patch for real

oops that was the original patch

[Stephanie Lewis]

Created attachment 229505 [details]
patch 4

Reversed the order of this patch and https://bugs.webkit.org/show_bug.cgi?id=131696 so it will apply cleanly

[Gavin Barraclough]

Comment on attachment 229505 [details]
patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=229505&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests since itâs not web exposed.

unicode character in change log.

[Stephanie Lewis]

Committed http://trac.webkit.org/changeset/167522

[Darin Adler]

Comment on attachment 229505 [details]
patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=229505&action=review

>> Source/WebCore/ChangeLog:9
>> +        No new tests since itâs not web exposed.
> 
> unicode character in change log.

Such characters are OK in Subversion and git, just not in the bugs.webkit.org patch review tool!