Bug 131693

Summary: [WK2] Move WebMouseEvent class to its own header file
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebCore Misc.Assignee: Jinwoo Song <jinwoo7.song>
Status: NEW    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Jinwoo Song
Reported 2014-04-15 13:36:52 PDT
SSIA.
Attachments
Patch (11.96 KB, patch)
2014-04-15 13:49 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (14.14 KB, patch)
2014-04-15 16:18 PDT, Jinwoo Song 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2014-04-15 13:49:50 PDT
Created attachment 229399 [details] Patch Working in progress.
Jinwoo Song
Comment 2 2014-04-15 16:18:38 PDT
Created attachment 229415 [details] Patch Attempt to fix build.
Darin Adler
Comment 3 2014-04-16 10:34:35 PDT
Comment on attachment 229415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229415&action=review > Source/WebKit2/Shared/WebEventConversion.cpp:29 > #include "WebEvent.h" Should remove this line. > Source/WebKit2/Shared/API/c/WKSharedAPICast.h:49 > #include "WebEvent.h" Should remove this line. > Source/WebKit2/Shared/efl/WebEventFactory.h:29 > #include "WebEvent.h" Should remove this line. > Source/WebKit2/Shared/gtk/WebEventFactory.h:30 > #include "WebEvent.h" Should remove this line. > Source/WebKit2/Shared/mac/NativeWebMouseEventMac.mm:32 > +#import "WebMouseEvent.h" This doesn’t seem right. Why do you need to add this include here? > Source/WebKit2/Shared/mac/WebEventFactory.h:29 > #import "WebEvent.h" Should remove this line. > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:32 > #include "WebEvent.h" Should remove this line. > Source/WebKit2/WebProcess/Plugins/Plugin.h:29 > +#include "WebMouseEvent.h" This doesn’t seem right. Why do you need to add this include here? > Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp:42 > #include "WebEvent.h" Should remove this line. > Source/WebKit2/WebProcess/Plugins/PluginView.cpp:33 > #include "WebEvent.h" Should remove this line. > Source/WebKit2/WebProcess/WebPage/FindController.h:32 > +#include "WebMouseEvent.h" This doesn’t seem right. Why do you need to add this include here?
Note You need to log in before you can comment on or make changes to this bug.