Bug 13165

Summary:

Using BUILDING_ON_TIGER in WebKit instead of local tests

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch v1	darin: review-
Patch v2	darin: review+

Description David Kilzer (:ddkilzer) 2007-03-22 16:57:34 PDT

Use the BUILDING_ON_TIGER macro in WebKitPrefix.h instead of scattering the same test throughout the code.

Comment 1 David Kilzer (:ddkilzer) 2007-03-22 16:59:00 PDT

Created attachment 13771 [details]
Patch v1

Comment 2 Darin Adler 2007-03-22 17:00:33 PDT

Comment on attachment 13771 [details]
Patch v1

The changes to header files are incorrect!

BUILDING_ON_TIGER is defined when building WebKit, but not by WebKit clients when including WebKit headers.

Comment 3 David Kilzer (:ddkilzer) 2007-03-22 17:02:07 PDT

Marking as INVALID since this can't be done.

Comment 4 David Kilzer (:ddkilzer) 2007-03-22 17:03:08 PDT

One of the changes may be landed.

Comment 5 David Kilzer (:ddkilzer) 2007-03-22 17:11:03 PDT

Created attachment 13772 [details]
Patch v2

Exclude public headers which don't get WebKitPrefix.h when building from clients.

Comment 6 Darin Adler 2007-03-22 17:19:13 PDT

Comment on attachment 13772 [details]
Patch v2

looks fine, r=me

Comment 7 David Kilzer (:ddkilzer) 2007-03-22 17:31:43 PDT

Committed revision 20412.