Bug 131615

Summary: fix potential truncation in x86assembler
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue, darin, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 8   
Attachments:
Description Flags
Patch none

Description Alex Christensen 2014-04-14 07:16:36 PDT 
My solution to https://bugs.webkit.org/show_bug.cgi?id=131508 truncates the size_t (which is a 64-bit integer) to an unsigned (which is a 32-bit integer in Windows) before taking the minimum of it an 15, which could lead to truncation problems.  Truncating after the call to std::min should fix it.
Comment 1 Alex Christensen 2014-04-14 07:17:35 PDT 
Created attachment 229281 [details]
Patch
Comment 2 Darin Adler 2014-04-14 08:30:12 PDT 
Comment on attachment 229281 [details]
Patch

Yes, this looks better.
Comment 3 WebKit Commit Bot 2014-04-14 09:32:10 PDT 
Comment on attachment 229281 [details]
Patch

Clearing flags on attachment: 229281

Committed r167250: <http://trac.webkit.org/changeset/167250>
Comment 4 WebKit Commit Bot 2014-04-14 09:32:13 PDT 
All reviewed patches have been landed.  Closing bug.