Summary: | [GTK] YouCompleteMe doesn't work for cmake build system. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ChangSeok Oh <changseok> | ||||||||
Component: | WebKitGTK | Assignee: | ChangSeok Oh <changseok> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, dbates, gustavo, mrobinson | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
ChangSeok Oh
2014-04-13 08:54:27 PDT
Created attachment 229238 [details]
Patch
Comment on attachment 229238 [details]
Patch
The Autotools build system has been removed. You probably need to update your patch to reflect that.
Created attachment 229292 [details]
Patch
*** Bug 131490 has been marked as a duplicate of this bug. *** Comment on attachment 229292 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229292&action=review > Tools/gtk/ycm_extra_conf.py:102 > + print "Could not find compile_commands.json in %s, You might forget to add CMAKE_EXPORT_COMPILE_COMMANDS=ON to cmakeargs" % build_path > return result Would it make sense to add this to build-webkit? Does it significantly slow cmake down? (In reply to comment #5) > (From update of attachment 229292 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=229292&action=review > > > Tools/gtk/ycm_extra_conf.py:102 > > + print "Could not find compile_commands.json in %s, You might forget to add CMAKE_EXPORT_COMPILE_COMMANDS=ON to cmakeargs" % build_path > > return result > > Would it make sense to add this to build-webkit? Does it significantly slow cmake down? No. I don't think it affects performance down. Actually I considered to add it in build-webkit, but I didn't becuase of non-vim user.(It's useless for them.) If no objection, let me add it. Thanks :) Created attachment 229371 [details]
Patch
Comment on attachment 229371 [details]
Patch
Thanks.
Comment on attachment 229371 [details] Patch Clearing flags on attachment: 229371 Committed r167482: <http://trac.webkit.org/changeset/167482> All reviewed patches have been landed. Closing bug. |