Bug 131591

Summary: [GTK] YouCompleteMe doesn't work for cmake build system.
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: WebKitGTKAssignee: ChangSeok Oh <changseok>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

ChangSeok Oh
Reported 2014-04-13 08:54:27 PDT
SSIA. I'm fixing this. A patch is coming soon.
Attachments
Patch (5.99 KB, patch)
2014-04-13 12:17 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (6.00 KB, patch)
2014-04-14 11:01 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Patch (6.49 KB, patch)
2014-04-15 08:45 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2014-04-13 12:17:56 PDT
Created attachment 229238 [details] Patch
Martin Robinson
Comment 2 2014-04-14 07:46:19 PDT
Comment on attachment 229238 [details] Patch The Autotools build system has been removed. You probably need to update your patch to reflect that.
ChangSeok Oh
Comment 3 2014-04-14 11:01:29 PDT
Created attachment 229292 [details] Patch
ChangSeok Oh
Comment 4 2014-04-14 11:07:01 PDT
*** Bug 131490 has been marked as a duplicate of this bug. ***
Martin Robinson
Comment 5 2014-04-14 11:14:39 PDT
Comment on attachment 229292 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229292&action=review > Tools/gtk/ycm_extra_conf.py:102 > + print "Could not find compile_commands.json in %s, You might forget to add CMAKE_EXPORT_COMPILE_COMMANDS=ON to cmakeargs" % build_path > return result Would it make sense to add this to build-webkit? Does it significantly slow cmake down?
ChangSeok Oh
Comment 6 2014-04-14 21:30:13 PDT
(In reply to comment #5) > (From update of attachment 229292 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=229292&action=review > > > Tools/gtk/ycm_extra_conf.py:102 > > + print "Could not find compile_commands.json in %s, You might forget to add CMAKE_EXPORT_COMPILE_COMMANDS=ON to cmakeargs" % build_path > > return result > > Would it make sense to add this to build-webkit? Does it significantly slow cmake down? No. I don't think it affects performance down. Actually I considered to add it in build-webkit, but I didn't becuase of non-vim user.(It's useless for them.) If no objection, let me add it. Thanks :)
ChangSeok Oh
Comment 7 2014-04-15 08:45:40 PDT
Created attachment 229371 [details] Patch
ChangSeok Oh
Comment 8 2014-04-17 21:35:37 PDT
Comment on attachment 229371 [details] Patch Thanks.
WebKit Commit Bot
Comment 9 2014-04-17 22:06:12 PDT
Comment on attachment 229371 [details] Patch Clearing flags on attachment: 229371 Committed r167482: <http://trac.webkit.org/changeset/167482>
WebKit Commit Bot
Comment 10 2014-04-17 22:06:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.