Bug 131567

Summary:

Need WK2 API to disable rubber-banding

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit API

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, sam, simon.fraser, thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Beth Dakin

Reported 2014-04-11 15:52:58 PDT

We need WK2 API to disable rubber-banding. <rdar://problem/15364278>

Attachments
Patch (15.13 KB, patch) 2014-04-11 15:57 PDT, Beth Dakin	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Beth Dakin

Comment 1 2014-04-11 15:57:56 PDT

Created attachment 229171 [details] Patch

Simon Fraser (smfr)

Comment 2 2014-04-11 16:16:10 PDT

Comment on attachment 229171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229171&action=review > Source/WebKit2/UIProcess/API/C/WKPage.h:185 > +WK_EXPORT bool WKPageVerticalRubberBandingIsDisabled(WKPageRef); > +WK_EXPORT void WKPageDisableVerticalRubberBanding(WKPageRef, bool disableVerticalRubberBanding); > +WK_EXPORT bool WKPageHorizontalRubberBandingIsDisabled(WKPageRef); > +WK_EXPORT void WKPageDisableHorizontalRubberBanding(WKPageRef, bool disableHorizontalRubberBanding); It would be slightly cleaner to have the API in positive terms (enabled, not disabled) I think. > Source/WebKit2/WebProcess/WebPage/WebPage.h:363 > + void disableVerticalRubberBanding(bool); > + void disableHorizontalRubberBanding(bool); I think setDisabled would be better terminology (or setEnabled if you want a positive term).

Beth Dakin

Comment 3 2014-04-11 16:52:55 PDT

Thanks, Simon! I switch the the positive terminology and the 'set' language. http://trac.webkit.org/changeset/167172

Note You need to log in before you can comment on or make changes to this bug.