Summary: | REGRESSION: Visual highlighting of pre-populated blank line in textarea is broken | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | Forms | Assignee: | mitz | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mitz | ||||||
Priority: | P1 | Keywords: | HasReduction, InRadar, Regression | ||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2007-03-21 21:20:01 PDT
Created attachment 13757 [details]
Test case
The root cause is the way pre-wrapped text behaves in WebCore. If you take something like <pre> foo </pre> and double- or triple-click the first (empty) line, nothing will be highlighted. Similarly if you triple-click "foo" only "foo" will be highlighted, not the entire line. When you enter the text manually, <br> elements are generated for the empty lines. Those highlight correctly. Another place where this behavior constitutes a regression is plain-text documents :-) Created attachment 13779 [details]
Highlight hard line breaks when their beginning is selected
Includes a pixel test, updated pixel results and change log entries.
Fixes this bug and another bug (also covered by the test) where the highlight did not extend to the end of the line if there were skipped spaces.
Committed revision 20459 |