Bug 131525

Summary:

Subpixel rendering: WK1: Trail of cruft in redraw during animations.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2014-04-10 20:34:39 PDT

Repaint rect is snapped to integral position which can result in cruft. Use enclosing integral rect for now  (until we transition views to device pixel boundaries).

Comment 1 zalan 2014-04-10 20:47:29 PDT

Created attachment 229101 [details]
Patch

Comment 2 zalan 2014-04-10 20:48:17 PDT

<rdar://problem/16359378>

Comment 3 Simon Fraser (smfr) 2014-04-10 22:02:35 PDT

Comment on attachment 229101 [details]
Patch

Can you explain in the change log why WK1 is different? It's not clear to me.

Comment 4 zalan 2014-04-11 09:13:29 PDT

Created attachment 229137 [details]
Patch

Comment 5 zalan 2014-04-11 09:15:29 PDT

(In reply to comment #3)
> (From update of attachment 229101 [details])
> Can you explain in the change log why WK1 is different? It's not clear to me.
Done. WK2 has compositing RenderView so RenderLayerBacking takes care of the repaintrects.

Comment 6 WebKit Commit Bot 2014-04-11 09:51:09 PDT

Comment on attachment 229137 [details]
Patch

Clearing flags on attachment: 229137

Committed r167129: <http://trac.webkit.org/changeset/167129>

Comment 7 WebKit Commit Bot 2014-04-11 09:51:13 PDT

All reviewed patches have been landed.  Closing bug.