Bug 131448

Summary: HTMLCollection::updateNamedElementCach iterates over items twice
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, esprehn+autocc, gyuyoung.kim, kling, koivisto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup kling: review+

Description Ryosuke Niwa 2014-04-09 12:27:10 PDT
HTMLCollection::updateNamedElementCach iterates over items twice
Comment 1 Ryosuke Niwa 2014-04-09 12:27:48 PDT
Created attachment 228973 [details]
Cleanup
Comment 2 Andreas Kling 2014-04-09 12:31:06 PDT
Comment on attachment 228973 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=228973&action=review

Well that was silly.

> Source/WebCore/ChangeLog:8
> +        Comptue the length first and go through the cache interface to traverse through items.

Compute
Comment 3 Ryosuke Niwa 2014-04-09 12:33:22 PDT
Committed r167028: <http://trac.webkit.org/changeset/167028>