Summary: | nil should only be used for objects | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Conrad Shultz <conrad_shultz> | ||||
Component: | WebCore Misc. | Assignee: | Conrad Shultz <conrad_shultz> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, eric.carlson, glenn, jcraig, jdiggs, jer.noble, mario, philipj, samuel_white, sergio, webkit-bug-importer | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Conrad Shultz
2014-04-08 23:02:24 PDT
Noticed there's a misuse of nil in -[WebViewFullScreenController setMediaElement:] too. Created attachment 228944 [details]
Patch
Comment on attachment 228944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228944&action=review > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:147 > + [player addObserver:self forKeyPath:@"rate" options:0 context:nullptr]; nullptr should probably be nil since this is an ObjC call (In reply to comment #3) > (From update of attachment 228944 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228944&action=review > > > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:147 > > + [player addObserver:self forKeyPath:@"rate" options:0 context:nullptr]; > > nullptr should probably be nil since this is an ObjC call The context: parameter is a void* though, so nullptr is correct. Comment on attachment 228944 [details] Patch Clearing flags on attachment: 228944 Committed r167003: <http://trac.webkit.org/changeset/167003> All reviewed patches have been landed. Closing bug. |