Bug 131431

Summary: nil should only be used for objects
Product: WebKit Reporter: Conrad Shultz <conrad_shultz>
Component: WebCore Misc.Assignee: Conrad Shultz <conrad_shultz>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, eric.carlson, glenn, jcraig, jdiggs, jer.noble, mario, philipj, samuel_white, sergio, webkit-bug-importer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Conrad Shultz
Reported 2014-04-08 23:02:24 PDT
-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:] should always return a BOOL.
Attachments
Patch (2.30 KB, patch)
2014-04-08 23:14 PDT, Conrad Shultz 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Conrad Shultz
Comment 1 2014-04-08 23:09:35 PDT
Noticed there's a misuse of nil in -[WebViewFullScreenController setMediaElement:] too.
Conrad Shultz
Comment 2 2014-04-08 23:14:02 PDT
Created attachment 228944 [details] Patch
chris fleizach
Comment 3 2014-04-08 23:18:34 PDT
Comment on attachment 228944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228944&action=review > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:147 > + [player addObserver:self forKeyPath:@"rate" options:0 context:nullptr]; nullptr should probably be nil since this is an ObjC call
Mark Rowe (bdash)
Comment 4 2014-04-08 23:19:46 PDT
(In reply to comment #3) > (From update of attachment 228944 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228944&action=review > > > Source/WebCore/platform/mac/WebVideoFullscreenController.mm:147 > > + [player addObserver:self forKeyPath:@"rate" options:0 context:nullptr]; > > nullptr should probably be nil since this is an ObjC call The context: parameter is a void* though, so nullptr is correct.
WebKit Commit Bot
Comment 5 2014-04-08 23:31:51 PDT
Comment on attachment 228944 [details] Patch Clearing flags on attachment: 228944 Committed r167003: <http://trac.webkit.org/changeset/167003>
WebKit Commit Bot
Comment 6 2014-04-08 23:31:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.