Bug 131421

Summary: Fix EFL Build errors since r166975.
Product: WebKit Reporter: Hyowon Kim <hw1008.kim>
Component: WebKit EFLAssignee: Hyowon Kim <hw1008.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, cmarcelo, commit-queue, gyuyoung.kim, lucas.de.marchi, luiz, noam, rakuco, sergio, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Description Hyowon Kim 2014-04-08 20:18:52 PDT 
EFL Build fix since r166956
Comment 1 Hyowon Kim 2014-04-08 20:26:27 PDT 
Created attachment 228930 [details]
Patch
Comment 2 Ryuan Choi 2014-04-08 20:30:56 PDT 
Comment on attachment 228930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228930&action=review

> Source/WebKit2/PlatformEfl.cmake:189
> +    WebProcess/WebPage/PageOverlayController.cpp

I think that this is not EFL specific
Comment 3 Gyuyoung Kim 2014-04-08 20:32:55 PDT 
Comment on attachment 228930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228930&action=review

> Source/WebKit2/ChangeLog:3
> +        EFL Build fix since r166956

I don't know why r166956 is involved in this build break. 

It looks the r166956 make bmalloc.

http://trac.webkit.org/changeset/166956
Comment 4 Hyowon Kim 2014-04-08 20:35:43 PDT 
(In reply to comment #3)
> (From update of attachment 228930 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228930&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        EFL Build fix since r166956
> 
> I don't know why r166956 is involved in this build break. 
> 
> It looks the r166956 make bmalloc.
> 
> http://trac.webkit.org/changeset/166956

Sorry r166975.
Comment 5 Hyowon Kim 2014-04-08 20:43:54 PDT 
Created attachment 228932 [details]
Patch
Comment 6 Hyowon Kim 2014-04-08 20:58:32 PDT 
I've filed a new bug 131425 to add additional implementation for page overlay.
Comment 7 Gyuyoung Kim 2014-04-08 22:51:02 PDT 
Comment on attachment 228932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228932&action=review

> Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp:73
> +        m_webPage->uninstallPageOverlay(m_overlay, PageOverlay::FadeMode::Fade);

BTW, should we modify this line ?
Comment 8 Gyuyoung Kim 2014-04-08 22:51:29 PDT 
Comment on attachment 228932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228932&action=review

> Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp:73
> +        m_webPage->uninstallPageOverlay(m_overlay, PageOverlay::FadeMode::Fade);

BTW, should we modify this line ?
Comment 9 Hyowon Kim 2014-04-08 22:58:05 PDT 
(In reply to comment #8)
> (From update of attachment 228932 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228932&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp:73
> > +        m_webPage->uninstallPageOverlay(m_overlay, PageOverlay::FadeMode::Fade);
> 
> BTW, should we modify this line ?

Yes, the second parameter was changed to enum class FadeMode.
Comment 10 WebKit Commit Bot 2014-04-08 23:26:03 PDT 
Comment on attachment 228932 [details]
Patch

Clearing flags on attachment: 228932

Committed r167002: <http://trac.webkit.org/changeset/167002>
Comment 11 WebKit Commit Bot 2014-04-08 23:26:09 PDT 
All reviewed patches have been landed.  Closing bug.