Bug 131402 – AX: Initial text selection point should respect element focus.

• Component: Accessibility
• Status: RESOLVED FIXED

[Samuel White]

When AX is running and we have no selection, pressing an arrow key initializes selection to the beginning of the document. Initial selection should respect and key off of the focused element if one is present. This would make it possible for a user to navigate halfway down a page using tab, and then hit an arrow key to start reading text from that point.

[Radar WebKit Bug Importer]

<rdar://problem/16558855>

[Samuel White]

Created attachment 228904 [details]
Patch for EWS.

No review needed. Just running through EWS.

[Samuel White]

Created attachment 228906 [details]
Patch.

Might as well update logs. :)

[chris fleizach]

Comment on attachment 228906 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=228906&action=review

> LayoutTests/platform/mac/accessibility/selection-initial.html:88
> +        //

This should just be one line I think

> LayoutTests/platform/mac/accessibility/selection-initial.html:131
> +        //

ditto

> Source/WebCore/page/EventHandler.cpp:3049
> +static void setKeyboardSelection(Frame& frame, SelectionDirection direction)

should this be setInitialKeyboardSelection

> Source/WebCore/page/EventHandler.cpp:3052
> +

you can remove this empty line

> Source/WebCore/ChangeLog:10
> +        Added function to set initial selection more gracefully. Specifically, when accessibility has the need to set initial selection,

move this explanation above the line about "No New Tests'

This should say something like
"Support the case where we want to set the initial selection and there's already a focused element."
The current wording is a bit backward in terms of importance

[Samuel White]

(In reply to comment #4)
> (From update of attachment 228906 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228906&action=review
> 
> > LayoutTests/platform/mac/accessibility/selection-initial.html:88
> > +        //
> 
> This should just be one line I think
> 
> > LayoutTests/platform/mac/accessibility/selection-initial.html:131
> > +        //
> 
> ditto
> 
> > Source/WebCore/page/EventHandler.cpp:3049
> > +static void setKeyboardSelection(Frame& frame, SelectionDirection direction)
> 
> should this be setInitialKeyboardSelection
> 
> > Source/WebCore/page/EventHandler.cpp:3052
> > +
> 
> you can remove this empty line
> 
> > Source/WebCore/ChangeLog:10
> > +        Added function to set initial selection more gracefully. Specifically, when accessibility has the need to set initial selection,
> 
> move this explanation above the line about "No New Tests'
> 
> This should say something like
> "Support the case where we want to set the initial selection and there's already a focused element."
> The current wording is a bit backward in terms of importance

Addressed all feedback and committed manually. Thanks.

[Samuel White]

http://trac.webkit.org/changeset/167033