Bug 131380

Summary:

[GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
Patch proposal	cfleizach: review+

Description Carlos Alberto Lopez Perez 2014-04-08 12:18:29 PDT

On platform GTK the following accessibility tests are failing:

* accessibility/children-changed-sends-notification.html
* accessibility/notification-listeners.html


The diffs are the following:

--- /stuff/webkit/webkit/layout-test-results/accessibility/children-changed-sends-notification-expected.txt
+++ /stuff/webkit/webkit/layout-test-results/accessibility/children-changed-sends-notification-actual.txt
@@ -6,12 +6,8 @@
 Plain text paragraph 

 End of test
-PARAGRAPH notification: AXChildrenRemoved
-GLOBAL notification: AXChildrenRemoved on element with role AXRole: AXParagraph
-PARAGRAPH notification: AXChildrenAdded
-GLOBAL notification: AXChildrenAdded on element with role AXRole: AXParagraph
 PASS paragraphNotificationCount is globalNotificationCount
-PASS globalNotificationCount is 2
+FAIL globalNotificationCount should be 2. Was 0.
 PASS successfullyParsed is true

 TEST COMPLETE

--- /stuff/webkit/webkit/layout-test-results/accessibility/notification-listeners-expected.txt
+++ /stuff/webkit/webkit/layout-test-results/accessibility/notification-listeners-actual.txt
@@ -7,11 +7,13 @@
 Slider
 SELECT AXInvalidStatusChanged
 GLOBAL AXInvalidStatusChanged on element with role AXRole: AXComboBox
+SLIDER AXChildrenAdded
+GLOBAL AXChildrenAdded on element with role AXRole: AXSlider
 SLIDER AXValueChanged
 GLOBAL AXValueChanged on element with role AXRole: AXSlider
 PASS selectNotificationCount is 1
-PASS sliderNotificationCount is 1
-PASS globalNotificationCount is 2
+FAIL sliderNotificationCount should be 1. Was 2.
+FAIL globalNotificationCount should be 2. Was 3.
 PASS successfullyParsed is true

 TEST COMPLETE

Comment 1 Mario Sanchez Prada 2014-04-09 07:37:48 PDT

Created attachment 228962 [details]
Patch proposal

Interestingly enough, we were avoiding to send the "add" signal for objects whose parents (where the signal will be emitted from) we knew in advance were not going to be exposed, but we did still emit the signal when the actual object being added would not be exposed, which is non sense.

We only should emit the add signal when both the object being added AND its parent are known not to be ignored from the accessibility tree.

Pleas review

Comment 2 Mario Sanchez Prada 2014-04-09 08:08:50 PDT

Committed r167012: <http://trac.webkit.org/changeset/167012>