Bug 131379

Summary: [GTK] [Stable] Backport "Allow passing extra initialization data to web extensions"
Product: WebKit Reporter: Sami Wagiaalla <swagiaal>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: cgarcia, gustavo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
A cherry pick of 4c113670 "Allow passing extra data to web extensions" none

Sami Wagiaalla
Reported 2014-04-08 11:59:13 PDT
The fix for Bug 125990 introduces great API. Would it make sense to backport this to the 2.2 series ? Should I add something tot he wiki ? I tried cherry-picking the patch and it seems to work correctly. I will attach my patch although I am not sure I have resolved conflicts correctly.
Attachments
A cherry pick of 4c113670 "Allow passing extra data to web extensions" (21.99 KB, patch)
2014-04-08 12:00 PDT, Sami Wagiaalla 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sami Wagiaalla
Comment 1 2014-04-08 12:00:55 PDT
Created attachment 228863 [details] A cherry pick of 4c113670 "Allow passing extra data to web extensions"
Carlos Garcia Campos
Comment 2 2014-05-03 02:50:58 PDT
New features and new API are not allowed in stable branches (unless there's a good reason and changes are very low risk ones). Why don't you upgrade to 2.4 instead?
Sami Wagiaalla
Comment 3 2014-05-05 07:03:18 PDT
(In reply to comment #2) > New features and new API are not allowed in stable branches Yeah, that makes sense. > Why don't you upgrade to 2.4 instead? That should not be a problem. The way I plan to implement this in Eclipse is to check for a minimum version of WebKit2 and if that is not available fall back on WebKit1. I just wanted to keep the WebKit2 version requirement as small as possible.
Note You need to log in before you can comment on or make changes to this bug.