| Summary: | [Win] Pass default parameters to cygwin setup wizard | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gomez Garcia <agomez> | ||||||
| Component: | Tools / Tests | Assignee: | Andres Gomez Garcia <agomez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, jhoneycutt, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 131365 | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gomez Garcia
2014-04-08 08:53:57 PDT
Created attachment 228844 [details]
Patch
Comment on attachment 228844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228844&action=review > Tools/CygwinDownloader/cygwin-downloader.py:165 > + os.execv("setup.exe", list(("-L", "-R", "C:\cygwin", "-l", os.getcwd(), "-P", ",".join(required_packages)))) Isn't this setup-x86.exe nowadays? Also, Cygwin might not be installed in C:\cygwin. Is there an environment/Registry setting we can use to identify where it should be? Comment on attachment 228844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228844&action=review >> Tools/CygwinDownloader/cygwin-downloader.py:165 >> + os.execv("setup.exe", list(("-L", "-R", "C:\cygwin", "-l", os.getcwd(), "-P", ",".join(required_packages)))) > > Isn't this setup-x86.exe nowadays? > > Also, Cygwin might not be installed in C:\cygwin. Is there an environment/Registry setting we can use to identify where it should be? The script already renames setup-x86.exe to setup.exe when performing the download. You are right about the installation path. I think the best would actually be to completely remove that option from the parameters. In the end, the setup wizard will still show us the option of changing the path and it seems already smart enough to chose C:/cygwin or whichever is the best suitable path. Created attachment 228952 [details]
Patch
Comment on attachment 228952 [details]
Patch
r=me.
Comment on attachment 228952 [details] Patch Clearing flags on attachment: 228952 Committed r167370: <http://trac.webkit.org/changeset/167370> All reviewed patches have been landed. Closing bug. |