Bug 131361

Summary: [Win] Pass default parameters to cygwin setup wizard
Product: WebKit Reporter: Andres Gomez Garcia <agomez>
Component: Tools / TestsAssignee: Andres Gomez Garcia <agomez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jhoneycutt, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 131365    
Attachments:
Description Flags
Patch
none
Patch none

Andres Gomez Garcia
Reported 2014-04-08 08:53:57 PDT
When running the cygwin installer we are told to set some of the options during cygwin installation in the setup wizard. This is not needed since the setup wizard accepts parameters itself.
Attachments
Patch (42.53 KB, patch)
2014-04-08 09:31 PDT, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
Patch (42.57 KB, patch)
2014-04-09 02:56 PDT, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gomez Garcia
Comment 1 2014-04-08 09:31:11 PDT
Created attachment 228844 [details] Patch
Brent Fulgham
Comment 2 2014-04-08 12:26:22 PDT
Comment on attachment 228844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228844&action=review > Tools/CygwinDownloader/cygwin-downloader.py:165 > + os.execv("setup.exe", list(("-L", "-R", "C:\cygwin", "-l", os.getcwd(), "-P", ",".join(required_packages)))) Isn't this setup-x86.exe nowadays? Also, Cygwin might not be installed in C:\cygwin. Is there an environment/Registry setting we can use to identify where it should be?
Andres Gomez Garcia
Comment 3 2014-04-09 02:26:17 PDT
Comment on attachment 228844 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228844&action=review >> Tools/CygwinDownloader/cygwin-downloader.py:165 >> + os.execv("setup.exe", list(("-L", "-R", "C:\cygwin", "-l", os.getcwd(), "-P", ",".join(required_packages)))) > > Isn't this setup-x86.exe nowadays? > > Also, Cygwin might not be installed in C:\cygwin. Is there an environment/Registry setting we can use to identify where it should be? The script already renames setup-x86.exe to setup.exe when performing the download. You are right about the installation path. I think the best would actually be to completely remove that option from the parameters. In the end, the setup wizard will still show us the option of changing the path and it seems already smart enough to chose C:/cygwin or whichever is the best suitable path.
Andres Gomez Garcia
Comment 4 2014-04-09 02:56:24 PDT
Created attachment 228952 [details] Patch
Brent Fulgham
Comment 5 2014-04-16 11:21:03 PDT
Comment on attachment 228952 [details] Patch r=me.
WebKit Commit Bot
Comment 6 2014-04-16 11:52:29 PDT
Comment on attachment 228952 [details] Patch Clearing flags on attachment: 228952 Committed r167370: <http://trac.webkit.org/changeset/167370>
WebKit Commit Bot
Comment 7 2014-04-16 11:52:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.