Bug 131350

Summary: [SOUP] Private browsing sessions should use a private cookie jar
Product: WebKit Reporter: youenn fablet <youennf>
Component: PlatformAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cdumez, cgarcia, commit-queue, danw, gustavo, mcatanzaro, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
rebasing patch none

youenn fablet
Reported 2014-04-08 00:20:13 PDT
When creating a private browsing session, SoupNetworkSession is reusing the default cookie jar. It should probably use a separate cookie jar, as seems to be the case for the CF layer (NetworkStorageSessionCFNet.cpp).
Attachments
Patch (7.63 KB, patch)
2014-04-08 00:49 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
rebasing patch (6.76 KB, patch)
2014-04-08 02:04 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2014-04-08 00:49:57 PDT
Created attachment 228818 [details] Patch
youenn fablet
Comment 2 2014-04-08 02:04:00 PDT
Created attachment 228821 [details] rebasing patch
Gustavo Noronha (kov)
Comment 3 2014-04-08 13:21:24 PDT
I don't think webkitgtk+ supports private sessions atm. Not against adding support for it, but will either or both of EFL or GTK+ actually use it?
youenn fablet
Comment 4 2014-04-09 01:28:52 PDT
(In reply to comment #3) > I don't think webkitgtk+ supports private sessions atm. Not against adding support for it, but will either or both of EFL or GTK+ actually use it? I am not sure of EFL. There is a webkitgtk "enable-private-browsing" property in webkitgtk doc. It is marked as experimental. This property value seems to propagate up to soup sessions.
youenn fablet
Comment 5 2014-04-09 07:54:56 PDT
I took a look at SoupNetworkSession.cpp commit history. Initially, createTestingSession and createPrivateBrowsingSession were ResourceHandle methods. createTestingSession was reusing the default cookie jar. createPrivateBrowsingSession was creating a new cookie jar. When moving those methods in SoupNetworkSession, this was swapped between the two methods.
Michael Catanzaro
Comment 6 2017-08-17 12:00:22 PDT
This is fixed in ephemeral mode.
Note You need to log in before you can comment on or make changes to this bug.