Bug 131343

Summary:

[Cocoa] Add WKFormDelegate

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Add _WKFormDelegate	andersca: review+

Description mitz 2014-04-07 20:13:41 PDT

[Cocoa] Add WKFormDelegate

Comment 1 mitz 2014-04-07 21:48:14 PDT

Created attachment 228801 [details]
Add _WKFormDelegate

Comment 2 Anders Carlsson 2014-04-08 08:30:22 PDT

Comment on attachment 228801 [details]
Add _WKFormDelegate

View in context: https://bugs.webkit.org/attachment.cgi?id=228801&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:145
> +    NSObject <NSSecureCoding> *_userObject;

Please use a RetainPtr here.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1946
>  - (void)_startAssistingNode:(const AssistedNodeInformation&)information userObject:(NSObject <NSSecureCoding> *)userObject

I think you should rename this method.

Comment 3 mitz 2014-04-08 10:18:23 PDT

Committed <http://trac.webkit.org/r166933>.