Bug 131343

Summary: [Cocoa] Add WKFormDelegate
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add _WKFormDelegate andersca: review+

mitz
Reported 2014-04-07 20:13:41 PDT
[Cocoa] Add WKFormDelegate
Attachments
Add _WKFormDelegate (20.76 KB, patch)
2014-04-07 21:48 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-04-07 21:48:14 PDT
Created attachment 228801 [details] Add _WKFormDelegate
Anders Carlsson
Comment 2 2014-04-08 08:30:22 PDT
Comment on attachment 228801 [details] Add _WKFormDelegate View in context: https://bugs.webkit.org/attachment.cgi?id=228801&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:145 > + NSObject <NSSecureCoding> *_userObject; Please use a RetainPtr here. > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1946 > - (void)_startAssistingNode:(const AssistedNodeInformation&)information userObject:(NSObject <NSSecureCoding> *)userObject I think you should rename this method.
mitz
Comment 3 2014-04-08 10:18:23 PDT
Committed <http://trac.webkit.org/r166933>.
Note You need to log in before you can comment on or make changes to this bug.