Summary: | Web Replay: memoize plugin data for navigator.mimeTypes and navigator.plugins | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||
Component: | Bindings | Assignee: | Brian Burg <burg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, commit-queue, joepeck, kling, sam, timothy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Brian Burg
2014-04-07 19:04:27 PDT
BTW: this API is being addressed now, because it is used by the google analytics urchin. So, basically every page hits it once, then makes a network request with a URL based on it. Created attachment 229012 [details]
the patch
Attachment 229012 [details] did not pass style-queue:
ERROR: Source/WebCore/replay/SerializationMethods.h:103: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/WebCore/replay/SerializationMethods.cpp:485: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 2 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Before landing I'm going to fix alphabetical sorting in SerializationMethods Created attachment 229070 [details]
reordered encode/decode methods
Attachment 229070 [details] did not pass style-queue:
ERROR: Source/WebCore/replay/SerializationMethods.h:103: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/WebCore/replay/SerializationMethods.cpp:456: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 2 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 229070 [details] reordered encode/decode methods Clearing flags on attachment: 229070 Committed r167085: <http://trac.webkit.org/changeset/167085> All reviewed patches have been landed. Closing bug. |