Bug 131309

Summary:

Handle clicks on DataDetectors UI for scanned phone numbers

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit2

Assignee:

Brady Eidson <beidson>

Status:

ASSIGNED ---

Severity:

Normal

CC:

commit-queue, joepeck, sam, thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch v1	thorton: review+

Description Brady Eidson 2014-04-07 12:13:55 PDT

Handle clicks on DataDetectors UI for scanned phone numbers

<rdar://problem/16379588>

Comment 1 Brady Eidson 2014-04-07 12:22:15 PDT

Created attachment 228751 [details]
Patch v1

Comment 2 WebKit Commit Bot 2014-04-07 12:23:29 PDT

Attachment 228751 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1232:  The parameter name "point" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Brady Eidson 2014-04-07 13:45:21 PDT

http://trac.webkit.org/changeset/166881

Comment 4 Joseph Pecoraro 2014-04-07 15:12:05 PDT

iOS build fix: <http://trac.webkit.org/changeset/166888>