Bug 131285

Summary:

Make some bindings improvements, with smaller code size for error message generation

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebCore JavaScript

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, cdumez, cgarcia, commit-queue, eric.carlson, glenn, jer.noble, jsbell, mkwst, philipj, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Darin Adler

Reported 2014-04-06 16:43:30 PDT

Make some bindings improvements, with smaller code size for error message generation

Attachments
Patch (318.71 KB, patch) 2014-04-06 16:55 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (318.66 KB, patch) 2014-04-06 16:59 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (320.32 KB, patch) 2014-04-06 17:19 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (324.22 KB, patch) 2014-04-06 18:19 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Patch (324.65 KB, patch) 2014-04-06 18:57 PDT, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2014-04-06 16:55:37 PDT

Created attachment 228707 [details] Patch

WebKit Commit Bot

Comment 2 2014-04-06 16:58:12 PDT

Attachment 228707 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4314: jsTestObjCONDITIONAL_CONST is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4320: jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4325: jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4330: jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4335: jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4340: jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4345: jsTestObjCONST_VALUE_9 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4355: jsTestObjCONST_VALUE_11 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4360: jsTestObjCONST_VALUE_12 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4365: jsTestObjCONST_VALUE_13 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4370: jsTestObjCONST_VALUE_14 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4375: jsTestObjCONST_JAVASCRIPT is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 12 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 3 2014-04-06 16:59:38 PDT

Created attachment 228708 [details] Patch

WebKit Commit Bot

Comment 4 2014-04-06 17:01:04 PDT

Attachment 228708 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4314: jsTestObjCONDITIONAL_CONST is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4320: jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4325: jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4330: jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4335: jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4340: jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4345: jsTestObjCONST_VALUE_9 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4355: jsTestObjCONST_VALUE_11 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4360: jsTestObjCONST_VALUE_12 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4365: jsTestObjCONST_VALUE_13 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4370: jsTestObjCONST_VALUE_14 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4375: jsTestObjCONST_JAVASCRIPT is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 12 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 5 2014-04-06 17:19:41 PDT

Created attachment 228709 [details] Patch

WebKit Commit Bot

Comment 6 2014-04-06 17:22:04 PDT

Attachment 228709 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4314: jsTestObjCONDITIONAL_CONST is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4320: jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4325: jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4330: jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4335: jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4340: jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4345: jsTestObjCONST_VALUE_9 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4355: jsTestObjCONST_VALUE_11 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4360: jsTestObjCONST_VALUE_12 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4365: jsTestObjCONST_VALUE_13 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4370: jsTestObjCONST_VALUE_14 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4375: jsTestObjCONST_JAVASCRIPT is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 12 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 7 2014-04-06 18:07:13 PDT

Comment on attachment 228709 [details] Patch r=me This should be nice for binary bloat. Take care to fix mac and windows builds before landing.

Darin Adler

Comment 8 2014-04-06 18:19:31 PDT

Created attachment 228711 [details] Patch

WebKit Commit Bot

Comment 9 2014-04-06 18:21:52 PDT

Attachment 228711 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4314: jsTestObjCONDITIONAL_CONST is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4320: jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4325: jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4330: jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4335: jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4340: jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4345: jsTestObjCONST_VALUE_9 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4355: jsTestObjCONST_VALUE_11 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4360: jsTestObjCONST_VALUE_12 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4365: jsTestObjCONST_VALUE_13 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4370: jsTestObjCONST_VALUE_14 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4375: jsTestObjCONST_JAVASCRIPT is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 12 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 10 2014-04-06 18:57:57 PDT

Created attachment 228712 [details] Patch

WebKit Commit Bot

Comment 11 2014-04-06 18:58:56 PDT

Attachment 228712 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4314: jsTestObjCONDITIONAL_CONST is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4320: jsTestObjCONST_VALUE_0 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4325: jsTestObjCONST_VALUE_1 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4330: jsTestObjCONST_VALUE_2 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4335: jsTestObjCONST_VALUE_4 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4340: jsTestObjCONST_VALUE_8 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4345: jsTestObjCONST_VALUE_9 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4355: jsTestObjCONST_VALUE_11 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4360: jsTestObjCONST_VALUE_12 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4365: jsTestObjCONST_VALUE_13 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4370: jsTestObjCONST_VALUE_14 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:4375: jsTestObjCONST_JAVASCRIPT is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 12 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Darin Adler

Comment 12 2014-04-06 20:44:04 PDT

Committed r166864: <http://trac.webkit.org/changeset/166864>

Darin Adler

Comment 13 2014-04-07 22:41:08 PDT

A fix for the isCalculated() assertion is in bug 131346. I can’t reproduce the m_table assertion locally, even though it seems to be firing on all the bots. I also have no theory about it yet.

Darin Adler

Comment 14 2014-04-07 22:41:29 PDT

(In reply to comment #13) > A fix for the isCalculated() assertion is in bug 131346. > > I can’t reproduce the m_table assertion locally, even though it seems to be firing on all the bots. I also have no theory about it yet. Oops, that comment is for a different bug.

Note You need to log in before you can comment on or make changes to this bug.