Bug 13127

Summary:

pass Frame context to ChromeClient::createWindow and friends

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

WebCore Misc.

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Minor

Priority:

Version:

523.x (Safari 3)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	mjs: review-
revised patch	mjs: review+

Darin Fisher (:fishd, Google)

Reported 2007-03-19 21:19:31 PDT

pass Frame context to ChromeClient::createWindow and friends currently, it is not possible to know what Frame is trying to open a window. it would be nice if there were a Frame pointer passed to createWindow and createModalDialog. runJavaScriptAlert and friends already have such a Frame pointer, so this change would just make the other methods on ChromeClient consistent.

Attachments
patch (9.32 KB, patch) 2007-03-19 22:12 PDT, Darin Fisher (:fishd, Google)	mjs: review-	Details Formatted Diff Diff
revised patch (11.73 KB, patch) 2007-03-21 15:30 PDT, Darin Fisher (:fishd, Google)	mjs: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Fisher (:fishd, Google)

Comment 1 2007-03-19 21:24:33 PDT

<ggaren> morganL: what would you use the context for? <morganL> ggaren: i would like to know which frame wants to open a window <morganL> ggaren: similar to how runJavaScriptAlert is given a Frame pointer <ggaren> morganL: that seems reasonable

Darin Fisher (:fishd, Google)

Comment 2 2007-03-19 22:12:19 PDT

Created attachment 13715 [details] patch A straightforward little patch.

Maciej Stachowiak

Comment 3 2007-03-21 15:13:34 PDT

Comment on attachment 13715 [details] patch - This breaks the Qt build, would be better not to do that. - Since the Frame argument is currently unused, it would be good to add a comment noting not to remove it, since people otherwise remove apparently dead code. r- for these two issues, otherwise works fine.

Darin Fisher (:fishd, Google)

Comment 4 2007-03-21 15:30:39 PDT

Created attachment 13750 [details] revised patch Revised as requested. Thanks!

Maciej Stachowiak

Comment 5 2007-03-21 19:41:12 PDT

Comment on attachment 13750 [details] revised patch r=me Committers, please let someone from Apple land this patch.

Mark Rowe (bdash)

Comment 6 2007-04-11 21:42:12 PDT

Landed in r20856.

Note You need to log in before you can comment on or make changes to this bug.