Bug 131268

Summary: Web Inspector: remove unused test hook setInspectorResourcesDataSizeLimits
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Brian Burg <burg>
Severity: Normal CC: ap, beidson, cmarcelo, commit-queue, graouts, joepeck, kondapallykalyan, luiz, noam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
the patch
the patch, with old protocols fixed
the patch none

Description Brian Burg 2014-04-05 11:21:12 PDT
This was used somehow to write tests for the network panel showing plugin network requests. I don't think we need this, unless there's some plan to start exposing plugin-related metrics.
Comment 1 Radar WebKit Bug Importer 2014-04-05 11:28:35 PDT
Comment 2 Timothy Hatcher 2014-04-05 13:51:43 PDT
Weird. This might be used for device emulation too, since iOS (and likely Android) have limits on the max size of resources.

That said, we don't need it. the iOS simulator or a device is the best way to test that.
Comment 3 Brian Burg 2014-04-05 13:58:44 PDT
Created attachment 228683 [details]
the patch
Comment 4 Brian Burg 2014-04-05 14:18:29 PDT
Created attachment 228684 [details]
the patch, with old protocols fixed
Comment 5 Brian Burg 2014-04-05 14:22:15 PDT
Comment on attachment 228684 [details]
the patch, with old protocols fixed

wrong bug, webkit-patch got confused
Comment 6 Brian Burg 2014-04-05 17:53:27 PDT
Created attachment 228691 [details]
the patch
Comment 7 WebKit Commit Bot 2014-04-05 22:56:25 PDT
Comment on attachment 228691 [details]
the patch

Clearing flags on attachment: 228691

Committed r166849: <http://trac.webkit.org/changeset/166849>
Comment 8 WebKit Commit Bot 2014-04-05 22:56:29 PDT
All reviewed patches have been landed.  Closing bug.