Bug 131241

Summary:

Web Inspector: Log JS Exceptions to System Console if JavaScriptCoreOutputConsoleMessagesToSystemConsole enabled

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2014-04-04 15:20:36 PDT

We do this in WebCore when enabling the system console logging. We should do this for exceptions as well.

I did not include the backtrace of the exception, but we could add that if we want to.

Comment 1 Radar WebKit Bug Importer 2014-04-04 15:21:10 PDT

<rdar://problem/16529729>

Comment 2 Joseph Pecoraro 2014-04-04 15:21:55 PDT

Created attachment 228620 [details]
[PATCH] Proposed Fix

Comment 3 Timothy Hatcher 2014-04-04 16:24:35 PDT

Comment on attachment 228620 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=228620&action=review

> Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:162
> +            ConsoleClient::printConsoleMessage(MessageSource::JS, MessageType::Log, MessageLevel::Error, errorMessage, callFrame.sourceURL(), callFrame.lineNumber(), callFrame.columnNumber());

Would be good to print the whole stack by passing in callStack and treating it like a console.trace.

Comment 4 WebKit Commit Bot 2014-04-04 16:55:25 PDT

Comment on attachment 228620 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 228620

Committed r166816: <http://trac.webkit.org/changeset/166816>

Comment 5 WebKit Commit Bot 2014-04-04 16:55:28 PDT

All reviewed patches have been landed.  Closing bug.