Bug 131232

Summary: [CSSRegions] Use RenderRegion::isValid() before using a region
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Mihnea Ovidenie 2014-04-04 10:40:32 PDT 
Make RenderRegion::isValid() the method to be used before doing something with a region instead of testing for flowThread() return value.
Comment 1 Mihnea Ovidenie 2014-04-04 10:52:46 PDT 
Created attachment 228605 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-04 10:54:55 PDT 
Attachment 228605 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/InspectorOverlay.cpp:683:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-04-06 00:24:43 PDT 
Comment on attachment 228605 [details]
Patch

r=me
Comment 4 Mihnea Ovidenie 2014-04-06 23:02:05 PDT 
Created attachment 228722 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2014-04-06 23:38:30 PDT 
Comment on attachment 228722 [details]
Patch for landing

Clearing flags on attachment: 228722

Committed r166867: <http://trac.webkit.org/changeset/166867>
Comment 6 WebKit Commit Bot 2014-04-06 23:38:33 PDT 
All reviewed patches have been landed.  Closing bug.