Summary: | Web Inspector: remove unused metrics and commands from the Timeline agent | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Burg <burg> | ||||||||
Component: | Web Inspector | Assignee: | Brian Burg <burg> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cmarcelo, commit-queue, graouts, joepeck, kondapallykalyan, luiz, noam, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Brian Burg
2014-04-03 15:03:33 PDT
Sounds good. This includes: - used heap size for every timeline record - begin/cancel frame messages, which were broken - runtime querying of feature support for features nobody implements Created attachment 228662 [details]
the patch
Comment on attachment 228662 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=228662&action=review > Source/WebCore/inspector/InspectorController.h:129 > void willComposite(); This too isn't used. > Source/WebCore/inspector/InspectorController.h:130 > void didComposite(); Ditto. > Source/WebCore/inspector/protocol/Timeline.json:-19 > - { "name": "usedHeapSize", "type": "integer", "optional": true, "description": "Current size of JS heap." } These should be removed from iOS 7 protocol files too. I do want to track rendered frames, but we can add it back at that time (likely with a better design.) (In reply to comment #6) > I do want to track rendered frames, but we can add it back at that time (likely with a better design.) Right. I kept the enum value in there because it would be useful to have this functionality. Just none of the existing plumbing works. (In reply to comment #5) > (From update of attachment 228662 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228662&action=review > > > Source/WebCore/inspector/InspectorController.h:129 > > void willComposite(); > > This too isn't used. > > > Source/WebCore/inspector/InspectorController.h:130 > > void didComposite(); > > Ditto. > > > Source/WebCore/inspector/protocol/Timeline.json:-19 > > - { "name": "usedHeapSize", "type": "integer", "optional": true, "description": "Current size of JS heap." } > > These should be removed from iOS 7 protocol files too. What about counters and other heap- and frame-related stuff in the protocol file that has never been used in the current inspector UI? Created attachment 228679 [details]
the patch, now with less didComposite
(In reply to comment #8) > (In reply to comment #5) > > (From update of attachment 228662 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=228662&action=review > > > > > Source/WebCore/inspector/InspectorController.h:129 > > > void willComposite(); > > > > This too isn't used. > > > > > Source/WebCore/inspector/InspectorController.h:130 > > > void didComposite(); > > > > Ditto. > > > > > Source/WebCore/inspector/protocol/Timeline.json:-19 > > > - { "name": "usedHeapSize", "type": "integer", "optional": true, "description": "Current size of JS heap." } > > > > These should be removed from iOS 7 protocol files too. > > What about counters and other heap- and frame-related stuff in the protocol file that has never been used in the current inspector UI? Yes, anything we have removed from TOT should be removed from the old protocols versions too. That way if we want to use those names in the future, we can feature check the protocol and only get the new version. We likely have missed some thing during removal. I pulled some things out the other day that I missed when cleaning up the profiler. (In reply to comment #7) > (In reply to comment #6) > > I do want to track rendered frames, but we can add it back at that time (likely with a better design.) > > Right. I kept the enum value in there because it would be useful to have this functionality. Just none of the existing plumbing works. We probably should remove the enums too — for completeness. Easy to add back later when needed. Comment on attachment 228679 [details] the patch, now with less didComposite View in context: https://bugs.webkit.org/attachment.cgi?id=228679&action=review > Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:-238 > -InspectorBackend.registerCommand("Timeline.supportsFrameInstrumentation", [], ["result"]); > -InspectorBackend.registerCommand("Timeline.canMonitorMainThread", [], ["result"]); This should be removed from the .json file in WebInspectorUI/Versions too. Created attachment 228687 [details]
the patch, with old protocols fixed
Committed r166846: <http://trac.webkit.org/changeset/166846> |