Bug 131167

Summary: Fix bit rot in ARMv7 JIT probe mechanism
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch none

Mark Lam
Reported 2014-04-03 10:09:44 PDT
This is just to get the ARMv7 JIT probe mechanism working again. The needed changes: 1. The macro assembler does not support pushing the SP register. Worked around this by pushing the LR register as a placeholder, and then writing the original SP value to that slot. 2. The CPUState field in the ProbeContext needs to be aligned on a 4 byte boundary, not an 8 byte boundary.
Attachments
the patch (2.28 KB, patch)
2014-04-03 10:13 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-04-03 10:13:53 PDT
Created attachment 228514 [details] the patch
Geoffrey Garen
Comment 2 2014-04-03 10:54:41 PDT
Comment on attachment 228514 [details] the patch r=me
WebKit Commit Bot
Comment 3 2014-04-03 11:25:52 PDT
Comment on attachment 228514 [details] the patch Clearing flags on attachment: 228514 Committed r166732: <http://trac.webkit.org/changeset/166732>
WebKit Commit Bot
Comment 4 2014-04-03 11:25:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.