Bug 131147

Summary: [Win] Turn on ENABLE_CSS_GRID_LAYOUT
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Brent Fulgham
Reported 2014-04-02 21:01:32 PDT
A few tests are failing on Windows because they expect ENABLE_CSS_GRID_LAYOUT to be activated. It seems to be activated for everyone else, let's turn it on!
Attachments
Patch (2.06 KB, patch)
2014-04-02 21:03 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (3.26 KB, patch)
2014-04-03 15:37 PDT, Brent Fulgham 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-04-02 21:03:08 PDT
Created attachment 228458 [details] Patch
Brent Fulgham
Comment 2 2014-04-03 00:09:42 PDT
Looks like a missing implementation file! Fixing...
Brent Fulgham
Comment 3 2014-04-03 15:31:21 PDT
This change allows Windows to pass the following tests: fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style.html
Brent Fulgham
Comment 4 2014-04-03 15:37:51 PDT
Created attachment 228551 [details] Patch
Brent Fulgham
Comment 5 2014-04-03 15:50:35 PDT
Committed r166749: <http://trac.webkit.org/changeset/166749>
Note You need to log in before you can comment on or make changes to this bug.