Bug 131095

Summary: [GTK][CMake] Look for glx.h in OPENGL_INCLUDE_DIR.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: New BugsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, gyuyoung.kim, mrobinson, sergio, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Raphael Kubo da Costa (:rakuco)
Reported 2014-04-02 01:22:37 PDT
[GTK][CMake] Look for glx.h in OPENGL_INCLUDE_DIR.
Attachments
Patch (1.97 KB, patch)
2014-04-02 01:24 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.97 KB, patch)
2014-04-03 00:27 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2014-04-02 01:24:09 PDT
Created attachment 228372 [details] Patch
Martin Robinson
Comment 2 2014-04-02 07:48:42 PDT
Comment on attachment 228372 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228372&action=review > Source/cmake/OptionsGTK.cmake:231 > +set(_required_includes_old ${CMAKE_REQUIRED_INCLUDES}) Why do you use the macro naming scheme here? I think this can be old_required_includes or OLD_REQUIRED_INCLUDES.
Raphael Kubo da Costa (:rakuco)
Comment 3 2014-04-02 07:55:07 PDT
Comment on attachment 228372 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228372&action=review >> Source/cmake/OptionsGTK.cmake:231 >> +set(_required_includes_old ${CMAKE_REQUIRED_INCLUDES}) > > Why do you use the macro naming scheme here? I think this can be old_required_includes or OLD_REQUIRED_INCLUDES. No particular reason, I just thought it would make sense to make the name look internal. I can change it to OLD_REQUIRED_INCLUDES before landing.
Martin Robinson
Comment 4 2014-04-02 08:00:40 PDT
Thanks for fixing!
Raphael Kubo da Costa (:rakuco)
Comment 5 2014-04-03 00:27:17 PDT
Created attachment 228479 [details] Patch for landing
Raphael Kubo da Costa (:rakuco)
Comment 6 2014-04-03 00:28:37 PDT
Committed r166702: <http://trac.webkit.org/changeset/166702>
Note You need to log in before you can comment on or make changes to this bug.