Bug 13108

Summary:

REGRESSION(r20269): frameborder attribute ignored

Product:

WebKit

Reporter:

Ain Tohvri <ain>

Component:

Frames

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hyatt

Priority:

Keywords:

Regression

Version:

523.x (Safari 3)

Hardware:

Mac (Intel)

OS:

OS X 10.4

URL:

http://www.seb.ee/index/1301

Attachments:

Description	Flags
frameborder set to 0 still displays	none
https://www.google.com/adsense/login3	none
Patch that fixes numerous bugs with frame borders and resizing	ggaren: review+

Ain Tohvri

Reported 2007-03-18 10:40:24 PDT

Sites that have frames with frameborder='0' still render frames

Attachments
frameborder set to 0 still displays (17.45 KB, image/png) 2007-03-18 10:42 PDT, Ain Tohvri	no flags	Details
https://www.google.com/adsense/login3 (47.24 KB, image/png) 2007-03-18 14:39 PDT, Ain Tohvri	no flags	Details
Patch that fixes numerous bugs with frame borders and resizing (16.88 KB, patch) 2007-03-18 18:04 PDT, Dave Hyatt	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ain Tohvri

Comment 1 2007-03-18 10:42:00 PDT

Created attachment 13692 [details] frameborder set to 0 still displays <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd"> <html> <head> <title>SEB Eesti Ühispank</title> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> <meta name="robots" content="all"> <meta name="robots" content="noarchive"> <meta name="robots" content="index, follow"> <meta name="rating" content="general"> <meta name="title" content="SEB Eesti Ühispank"> <meta name="description" content=""> <meta name="keywords" content=""> </head> <frameset rows="84,*"> <frame src="/show/topmenu/0101" name="header" frameborder="0" noresize="noresize" scrolling="no" marginheight="0" marginwidth="10" /> <frameset cols="180,*"> <frame src="/show/menu/0101" name="lmenu" frameborder="0" marginheight="0" marginwidth="10" noresize scrolling="no" /> <frame src="/page/0101" name="main" frameborder="0" marginheight="0" marginwidth="0" scrolling="auto" noresize /> </frameset> </frameset> </html>

Geoffrey Garen

Comment 2 2007-03-18 11:01:19 PDT

This is a recent (past day or two) regression in TOT. Marking P1.

Dave Hyatt

Comment 3 2007-03-18 13:11:03 PDT

I see what I messed up. This is easy to fix. The space is still supposed to be there.. the borders just don't render.

Ain Tohvri

Comment 4 2007-03-18 13:18:30 PDT

(In reply to comment #3) > I see what I messed up. This is easy to fix. The space is still supposed to be > there.. the borders just don't render. > Good news. Just to note that it affects IFRAME as well.

Dave Hyatt

Comment 5 2007-03-18 14:20:53 PDT

It does? iframe should be fixed.

Dave Hyatt

Comment 6 2007-03-18 14:21:10 PDT

Could you attach an iframe example?

Ain Tohvri

Comment 7 2007-03-18 14:39:34 PDT

Created attachment 13694 [details] https://www.google.com/adsense/login3 Google AdSense login page uses IFRAME that renders frames despite the 0 attribute

Dave Hyatt

Comment 8 2007-03-18 18:04:34 PDT

Created attachment 13700 [details] Patch that fixes numerous bugs with frame borders and resizing

Geoffrey Garen

Comment 9 2007-03-18 18:56:45 PDT

Comment on attachment 13700 [details] Patch that fixes numerous bugs with frame borders and resizing please add changelog + tests before landing.

Dave Hyatt

Comment 10 2007-03-18 22:08:31 PDT

Fixed.

Note You need to log in before you can comment on or make changes to this bug.