Bug 131071 – willReveal edge events should be hooked up for overflow:scroll

• Component: DOM
• Status: RESOLVED FIXED

[Beth Dakin]

Our new willRevealBottom/Top/Left/Right events should be hooked up for overflow:scroll.

<rdar://problem/16190392>

[Beth Dakin]

Created attachment 228329 [details]
Patch

[WebKit Commit Bot]

Attachment 228329 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:5623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

Created attachment 228330 [details]
Patch

[WebKit Commit Bot]

Attachment 228330 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:5623:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 228330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228330&action=review

> Source/WebCore/dom/Document.cpp:5618
> +     // For each edge (top, bottom, left and right), send the will reveal edge event for that direction

You have an extra space here.

> Source/WebCore/dom/Document.h:1177
> +    void sendWillRevealEdgeEventsIfNeeded(const IntPoint& oldPosition, const IntPoint& newPosition, const IntRect& visibleRect, const IntSize& contentsSize, Element* target = 0);

You should use Element* target = nullptr.  I would also rename this to enqueueWillRevealEdgeEventsIfNeeded.  This might also be better on the DocumentEventQueue class, not sure.

[Beth Dakin]

(In reply to comment #5)
> (From update of attachment 228330 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=228330&action=review
> 
> > Source/WebCore/dom/Document.cpp:5618
> > +     // For each edge (top, bottom, left and right), send the will reveal edge event for that direction
> 
> You have an extra space here.
> 
> > Source/WebCore/dom/Document.h:1177
> > +    void sendWillRevealEdgeEventsIfNeeded(const IntPoint& oldPosition, const IntPoint& newPosition, const IntRect& visibleRect, const IntSize& contentsSize, Element* target = 0);
> 
> You should use Element* target = nullptr.  I would also rename this to enqueueWillRevealEdgeEventsIfNeeded.  This might also be better on the DocumentEventQueue class, not sure.

Fixed both. Thanks, Sam! http://trac.webkit.org/changeset/166630